-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0] [MIG] users ldap mail #2
Conversation
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
* [ADD] Add README.rst to users_ldap_mail * [MIG] Migrate users_ldap_mail to 10.0 * [FIX] Fixes in code style in module users_ldap_mail Changes in models/users_ldap_mail include: - remove unused imports - indentation of too long lines * [FIX] users_ldap_mail: Fix copyright notice * [FIX] users_ldap_mail: set UTF-8 encoding users_ldap_mail/models/__init__.py should be UTF-8 encoded * [FIX] users_ldap_mail: remove size argument from Char fields * [FIX] users_ldap_mail: return value can be combined in one line * [FIX] Update read me Fixes included: - Make module name human readable - Instead of numbering steps, use # - Update broken link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. Thanks!
users_ldap_mail/__manifest__.py
Outdated
@@ -4,7 +4,7 @@ | |||
|
|||
{ | |||
'name': "LDAP mapping for user name and e-mail", | |||
'version': "10.0.1.0.0", | |||
'version': "11.0.1.0.0", | |||
'depends': ["auth_ldap"], | |||
'author': "Daniel Reis (https://launchpad.com/~dreis-pt)," |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dreispt - are you good with removing your launchpad from this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, of course 😄
@@ -0,0 +1,15 @@ | |||
<?xml version="1.0"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please align file name with contribution guidelines
res_company_ldap_view.xml
6c1a2ca
to
74bc9a1
Compare
74bc9a1
to
d427cd6
Compare
This one is ready to merge. |
I think this is the first v11 I've merged. Merging this many commits is intimidating. |
Btw thanks @etobella! 😉 |
@lasley Not really: only the two last commits are new; the rest is just module history. |
Added extra authorize params. Fixed pre-commit errors and remove comm…
Migration to 11.0.
Same code that existed on #1 and OCA/server-tools#1018.