Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0] [MIG] users ldap mail #2

Merged
merged 31 commits into from
Oct 20, 2017
Merged

Conversation

etobella
Copy link
Member

Migration to 11.0.
Same code that existed on #1 and OCA/server-tools#1018.

dreispt and others added 29 commits October 10, 2017 17:03
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
* [ADD] Add README.rst to users_ldap_mail

* [MIG] Migrate users_ldap_mail to 10.0

* [FIX] Fixes in code style in module  users_ldap_mail

Changes in models/users_ldap_mail include:
 - remove unused imports
 - indentation of too long lines

* [FIX] users_ldap_mail: Fix copyright notice

* [FIX] users_ldap_mail: set UTF-8 encoding

users_ldap_mail/models/__init__.py should be UTF-8 encoded

* [FIX] users_ldap_mail: remove size argument from Char fields

* [FIX] users_ldap_mail: return value can be combined in one line

* [FIX] Update read me

Fixes included:
 - Make module name human readable
 - Instead of numbering steps, use #
 - Update broken link
Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Thanks!

@@ -4,7 +4,7 @@

{
'name': "LDAP mapping for user name and e-mail",
'version': "10.0.1.0.0",
'version': "11.0.1.0.0",
'depends': ["auth_ldap"],
'author': "Daniel Reis (https://launchpad.com/~dreis-pt),"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreispt - are you good with removing your launchpad from this?

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, of course 😄

@@ -0,0 +1,15 @@
<?xml version="1.0"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align file name with contribution guidelines

res_company_ldap_view.xml

@JordiBForgeFlow
Copy link
Sponsor Member

This one is ready to merge.

@lasley lasley merged commit ccbde61 into OCA:11.0 Oct 20, 2017
@lasley
Copy link
Contributor

lasley commented Oct 20, 2017

I think this is the first v11 I've merged. Merging this many commits is intimidating.

@lasley
Copy link
Contributor

lasley commented Oct 20, 2017

Btw thanks @etobella! 😉

@dreispt
Copy link
Sponsor Member

dreispt commented Oct 22, 2017

@lasley Not really: only the two last commits are new; the rest is just module history.

@pedrobaeza
Copy link
Member

@pedrobaeza pedrobaeza added this to the 11.0 milestone Oct 31, 2017
lalithkota pushed a commit to lalithkota/oca-server-auth that referenced this pull request Aug 3, 2023
Added extra authorize params. Fixed pre-commit errors and remove comm…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet