[17.0][MIG] partner_contact_sale_info_propagation #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[UPD] Update partner_contact_sale_info_propagation.pot
…hange partner propagation. TT27986
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-partner_contact_sale_info_propagation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-partner_contact_sale_info_propagation/
Currently translated at 100.0% (1 of 1 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-partner_contact_sale_info_propagation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-partner_contact_sale_info_propagation/de/
Currently translated at 100.0% (1 of 1 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-partner_contact_sale_info_propagation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-partner_contact_sale_info_propagation/it/
67 tasks
|
/ocabot migration partner_contact_sale_info_propagation |
| return super().create(vals_list) | ||
|
|
||
| @api.onchange("parent_id") | ||
| def onchange_parent_id(self): |
There was a problem hiding this comment.
IMHO, this should be changed to use the compute method instead.
See: https://github.com/odoo/odoo/blob/17.0/odoo/addons/base/models/res_partner.py#L370
There was a problem hiding this comment.
Yeah you're right, ill work on it.
Deriman-Alonso
force-pushed
the
17.0-mig-partner_contact_sale_info_propagation
branch
2 times, most recently
from
ca4f9a1
to
d427037
Compare
Deriman-Alonso
force-pushed
the
17.0-mig-partner_contact_sale_info_propagation
branch
from
d427037
to
248a8d9
Compare
FrancoMaxime
suggested changes
May 20, 2024
Comment on lines
27
to
36
| childs = record.mapped("child_ids").filtered( | ||
| lambda r: not r.user_id or r.user_id == record.user_id | ||
| lambda r, record=record: not r.user_id | ||
| or r.user_id == record.user_id | ||
| ) | ||
| if childs: | ||
| childs.write({"user_id": vals["user_id"]}) | ||
| if "team_id" in vals: | ||
| childs = record.mapped("child_ids").filtered( | ||
| lambda r: not r.team_id or r.team_id == record.team_id | ||
| lambda r, record=record: not r.team_id | ||
| or r.team_id == record.team_id |
There was a problem hiding this comment.
Hi @Deriman-Alonso ,
Thanks a lot for your pull request.
Why are we keeping record.mapped("child_ids") and not using directly record.child_ids since record contains only one element.
If I read the documentation correctly (Doc mapped) doing record.mapped(child_ids) is equivalent to record.child_ids.
Comment on lines
54
to
55
| @api.onchange("parent_id") | ||
| def onchange_parent_id(self): | ||
| def _compute_user_id(self): |
There was a problem hiding this comment.
Since this commit user_id is a computed field, so its need an @api.depends and not an @api.onchange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standart migration.