[16.0][FIX] sale_order_carrier_auto_assign: fix all service #3088
+93
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaudoux
force-pushed
the
16-imp_sale_order_carrier_auto_assign-service
branch
3 times, most recently
from
3279619
to
c5e7118
Compare
santostelmo
approved these changes
Apr 19, 2024
jbaudoux
force-pushed
the
16-imp_sale_order_carrier_auto_assign-service
branch
from
c5e7118
to
bfa00bb
Compare
sebalix
reviewed
Apr 23, 2024
| @@ -4,10 +4,10 @@ | |||
| "name": "Sale Order Carrier Auto Assign", | |||
| "summary": "Auto assign delivery carrier on sale order confirmation", | |||
| "version": "16.0.1.1.0", | |||
| "development_status": "Alpha", | |||
There was a problem hiding this comment.
If it's not Alpha, is it Beta/Mature/Production/Stable?
I think we should not remove it, I do not know the default value...?
|
@sebalix Can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not add carrier when SO contains only service lines
Also increased test coverage
Removed Alpha status
@sebalix @simahawk @santostelmo