New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] [15.0] sale_warn_option #3076
[ADD] [15.0] sale_warn_option #3076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
c758cab
to
06ef6b1
Compare
/ocabot rebase |
Sorry @Shide you are not allowed to rebase. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
06ef6b1
to
f7d14e1
Compare
/ocabot rebase |
@rafaelbn The rebase process failed, because command
|
f7d14e1
to
5d524a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Shide, it's a very good module. Just documentation changes and a question why not use compute to set msg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO: Maybe add doc configuration, if you don't know about activate sale warnings, you don't test or use module.
@@ -0,0 +1,6 @@ | |||
To use this module, you need to: | |||
|
|||
- Go to a Customer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Go to a Customer | |
- Go to Sales > Orders > Customers. |
To use this module, you need to: | ||
|
||
- Go to a Customer | ||
- Select Warn Options under _Warning on the Sales Order_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Select Warn Options under _Warning on the Sales Order_ | |
- In Internal Notes tab select Warn Options under _Warning on the Sales Order_ |
|
||
- Go to a Customer | ||
- Select Warn Options under _Warning on the Sales Order_ | ||
- Go to a Product |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Go to a Product | |
- Go to Sales > Products > Products. |
- Go to a Customer | ||
- Select Warn Options under _Warning on the Sales Order_ | ||
- Go to a Product | ||
- Select Warn Options under _Warning when Selling this Product_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Select Warn Options under _Warning when Selling this Product_ | |
- In a Sales tab select Warn Options under _Warning when Selling this Product_ |
Please @Shide could you review @EmilioPascual comments with ❤️ ? Thank you! 😄 |
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at a513e9f. Thanks a lot for contributing to OCA. ❤️ |
This module extends the functionality of blocking messages to support more consistency
between messages and to allow you to set a blocking message quickly.
This is a PR of a series:
base_warn_option
purchase_warn_option
account_warn_option
stock_warn_option
MT-5193 @moduon @rafaelbn @yajo @EmilioPascual please review if you want :)