Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] [15.0] sale_warn_option #3076

Merged

Conversation

Shide
Copy link
Contributor

@Shide Shide commented Apr 16, 2024

This module extends the functionality of blocking messages to support more consistency
between messages and to allow you to set a blocking message quickly.

This is a PR of a series:

base_warn_option
purchase_warn_option
account_warn_option
stock_warn_option

MT-5193 @moduon @rafaelbn @yajo @EmilioPascual please review if you want :)

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

sale_warn_option/__manifest__.py Outdated Show resolved Hide resolved
sale_warn_option/readme/CONTEXT.md Outdated Show resolved Hide resolved
sale_warn_option/tests/test_abstract_something.py Outdated Show resolved Hide resolved
sale_warn_option/tests/test_something.py Outdated Show resolved Hide resolved
@Shide Shide marked this pull request as draft April 16, 2024 10:37
@Shide Shide force-pushed the 15.0-sale_warn_option-sale_warn_option branch from c758cab to 06ef6b1 Compare April 16, 2024 10:49
@Shide Shide marked this pull request as ready for review April 16, 2024 11:01
@Shide Shide requested a review from yajo April 16, 2024 11:08
@Shide
Copy link
Contributor Author

Shide commented Apr 16, 2024

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Sorry @Shide you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@Shide Shide force-pushed the 15.0-sale_warn_option-sale_warn_option branch from 06ef6b1 to f7d14e1 Compare April 16, 2024 11:17
@rafaelbn rafaelbn added this to the 15.0 milestone Apr 16, 2024
@rafaelbn
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@rafaelbn The rebase process failed, because command git push --force moduon tmp-pr-3076:15.0-sale_warn_option-sale_warn_option failed with output:

remote: Permission to moduon/sale-workflow.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/moduon/sale-workflow/': The requested URL returned error: 403

@Shide Shide force-pushed the 15.0-sale_warn_option-sale_warn_option branch from f7d14e1 to 5d524a9 Compare April 17, 2024 07:41
Copy link
Contributor

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shide, it's a very good module. Just documentation changes and a question why not use compute to set msg

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO: Maybe add doc configuration, if you don't know about activate sale warnings, you don't test or use module.

@@ -0,0 +1,6 @@
To use this module, you need to:

- Go to a Customer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Go to a Customer
- Go to Sales > Orders > Customers.

To use this module, you need to:

- Go to a Customer
- Select Warn Options under _Warning on the Sales Order_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Select Warn Options under _Warning on the Sales Order_
- In Internal Notes tab select Warn Options under _Warning on the Sales Order_


- Go to a Customer
- Select Warn Options under _Warning on the Sales Order_
- Go to a Product
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Go to a Product
- Go to Sales > Products > Products.

- Go to a Customer
- Select Warn Options under _Warning on the Sales Order_
- Go to a Product
- Select Warn Options under _Warning when Selling this Product_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Select Warn Options under _Warning when Selling this Product_
- In a Sales tab select Warn Options under _Warning when Selling this Product_

sale_warn_option/models/product_template.py Show resolved Hide resolved
@rafaelbn
Copy link
Member

Please @Shide could you review @EmilioPascual comments with ❤️ ? Thank you! 😄

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-3076-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 52054e5 into OCA:15.0 May 6, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a513e9f. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 15.0-sale_warn_option-sale_warn_option branch May 7, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants