[15.0][IMP] sale_planner_calendar: Design improves and new buttons in calendar planner event #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pilarvargas-tecnativa
force-pushed
the
15.0-imp-sale_planner_calendar
branch
from
a17aa9d
to
14666e1
Compare
CarlosRoca13
approved these changes
Apr 16, 2024
pilarvargas-tecnativa
force-pushed
the
15.0-imp-sale_planner_calendar
branch
4 times, most recently
from
9db7003
to
b44452e
Compare
chienandalu
suggested changes
Apr 17, 2024
There was a problem hiding this comment.
Some code review and light testing:
- Add a description of tasks done in the commit
- Also add in the readme the new relevant features and how to use them
- Testing I came across this error:
url = partner_latitude + "%2C" + partner_longitude
Exception
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/opt/odoo/odoo/http.py", line 658, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/opt/odoo/odoo/http.py", line 301, in _handle_exception
raise exception.with_traceback(None) from new_cause
TypeError: unsupported operand type(s) for +: 'float' and 'str'
7d35bbd
to
ff2e040
Compare
…dar planner event Improvements made: - Profile for calendar events that will allow an icon to be displayed in the kanban view of the visit. It can also be configured from a recurring event. - Tree view to edit and add new profiles with their icons which will be fontawesome text strings (e.g fa-user). - New buttons in the kanban view of the visit: Location, Whatsapp - Some improvements in the structure to make it responsive with the new addition of buttons that may or may not be visible. TT48632
pilarvargas-tecnativa
force-pushed
the
15.0-imp-sale_planner_calendar
branch
from
ff2e040
to
29a9c84
Compare
pedrobaeza
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT48632
@pedrobaeza @sergio-teruel @CarlosRoca13 please review