[16.0][MIG] sale_order_line_description #3070
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-11.0/sale-workflow-11.0-sale_order_line_description Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_order_line_description/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_description Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_description/
Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_description Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_description/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_description Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_description/
Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_description Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_description/de/
Currently translated at 85.7% (6 of 7 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_description Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_description/fr/
Currently translated at 60.0% (6 of 10 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_description Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_description/fr_FR/
Currently translated at 14.2% (1 of 7 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_line_description Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_line_description/it/
Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_line_description Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_line_description/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_line_description Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_line_description/
|
/ocabot migration sale_order_line_description |
rousseldenis
requested changes
Apr 15, 2024
There was a problem hiding this comment.
@mariobinhex Thanks for this.
Usually, it's fair to base your PR on other one to integrate the previous work (from #2450).
Moreover, his code was better than this one.
Could you change ? Thanks
| @@ -8,8 +8,8 @@ class SaleOrderLine(models.Model): | |||
| _inherit = "sale.order.line" | |||
|
|
|||
| @api.onchange("product_id") | |||
| def product_id_change(self): | |||
| res = super(SaleOrderLine, self).product_id_change() | |||
| def _onchange_product_id_warning(self): | |||
There was a problem hiding this comment.
Please use _compute_name() function instead.
| @@ -57,6 +58,7 @@ def test_check_sale_order_line_description(self): | |||
| sale_order_line = self.sale_order_line_model.with_user(self.user_1).create( | |||
| line_values.copy() | |||
| ) | |||
| sale_order_line._onchange_product_id_warning() | |||
There was a problem hiding this comment.
After having changed to _compute_name() override, you don't need this anymore
There was a problem hiding this comment.
@rousseldenis Hi and thanks for the review
Pls check my changes and let me know if any further changes are needed.
Greetings!
| class SaleOrderLine(models.Model): | ||
| _inherit = "sale.order.line" | ||
|
|
||
| @api.onchange("product_id") |
There was a problem hiding this comment.
It should be @api.depends.
There was a problem hiding this comment.
@AungKoKoLin1997 Thanks for the review
Done!
Jaimermaccione
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last PR of migration module in open stage: #2450