New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] pricelist_cache: update price cache in chuncks #3060
Open
vuwnevska
wants to merge
5
commits into
OCA:14.0
Choose a base branch
from
vuwnevska:imp_pricelist_cache_14.0
base: 14.0
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuwnevska
changed the title
pricelist_cache: update price cache in chuncks
[IMP] pricelist_cache: update price cache in chuncks
Apr 8, 2024
vuwnevska
force-pushed
the
imp_pricelist_cache_14.0
branch
from
April 8, 2024 19:58
c5c1614
to
c46789c
Compare
vuwnevska
force-pushed
the
imp_pricelist_cache_14.0
branch
2 times, most recently
from
April 8, 2024 20:45
0c6df85
to
9999409
Compare
vuwnevska
force-pushed
the
imp_pricelist_cache_14.0
branch
from
April 8, 2024 20:59
9999409
to
52c962d
Compare
mt-software-de
suggested changes
Apr 29, 2024
Co-authored-by: Michael Tietz <78783475+mt-software-de@users.noreply.github.com>
vuwnevska
force-pushed
the
imp_pricelist_cache_14.0
branch
from
May 3, 2024 09:04
1899d3e
to
215458c
Compare
vuwnevska
force-pushed
the
imp_pricelist_cache_14.0
branch
from
May 3, 2024 09:27
215458c
to
c4df585
Compare
Co-authored-by: Michael Tietz <78783475+mt-software-de@users.noreply.github.com>
Comment on lines
+153
to
+159
template_items = pricelist.item_ids.filtered( | ||
lambda i: i.product_tmpl_id.product_variant_ids | ||
) | ||
if template_items: | ||
variants_ids = template_items.product_tmpl_id.product_variant_ids | ||
if any([True for id in variants_ids.ids if id in product_ids]): | ||
product_ids_to_update.extend(variants_ids.ids) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be good to have it in one loop with the first. item_ids.filtered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for big updates even a delayed job cannot handle the update, to avoid this perform product search before job is created