Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] sale_global_discount: 17.0 #3025

Open
wants to merge 40 commits into
base: 17.0
Choose a base branch
from

Conversation

miguel-S73
Copy link
Contributor

chienandalu and others added 30 commits March 18, 2024 10:37
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-11.0/sale-workflow-11.0-sale_global_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_global_discount/es/
Not all taxes combinations are possible with global discounts when they are later
invoiced and posted, so we need to constraint them early.

OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly
taxes for supported cases, and constraining the rest.

We apply here the same constraints at sales order level. Existing tests have been
changed because they were using one of the forbidden taxes combination, and 2 new
tests have been added for covering the new constraints.
* Standard procedure
* Code adaptation
* README regeneration
* Tests adaptation

[UPD] Update sale_global_discount.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/
Currently translated at 100.0% (9 of 9 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/pt/
Currently translated at 100.0% (9 of 9 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/pt/
The tuple has changed from 4 to 6 elements.

[UPD] Update sale_global_discount.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/
Only global discount managers can set global discounts

[UPD] Update sale_global_discount.pot
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/
[UPD] Update sale_global_discount.pot
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/

[UPD] Update sale_global_discount.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/
Currently translated at 100.0% (10 of 10 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/pt/
Currently translated at 100.0% (10 of 10 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/es/
[UPD] Update sale_global_discount.pot

[UPD] README.rst
This one is not present anymore in this version.
…sts to prevent errors if company have default currency distinct to default priceslist
…e other standard computed fields in same method are
Currently translated at 100.0% (13 of 13 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_global_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_global_discount/it/
…of base_global_discount

In this way we also include the following configuration step:
* Go to *Settings > Users*, choose yours and set *Manage Global Discounts*

Without this *Global Discounts* doesn't show up!
@miguel-S73 miguel-S73 force-pushed the 17.0-mig-sale_global_discount branch from d792d64 to 267873a Compare March 18, 2024 10:29
@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration sale_global_discount

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet