Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP]sale_delivery_state: Skip sale order lines for delivery state #2845

Merged
merged 1 commit into from
Dec 19, 2023
Merged

[IMP]sale_delivery_state: Skip sale order lines for delivery state #2845

merged 1 commit into from
Dec 19, 2023

Conversation

manuelregidor
Copy link
Contributor

Based on #2818

@manuelregidor
Copy link
Contributor Author

manuelregidor commented Dec 12, 2023 •
edited

@HaraldPanten @ValentinVinagre @etobella @yostashiro Could you review, please? Thank you.

ValentinVinagre
ValentinVinagre approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@manuelregidor
Copy link
Contributor Author

manuelregidor commented Dec 12, 2023 •
edited

There is a failing test from sale_by_packaging but it doesn't seem to be related to this imp.

@HaraldPanten
Copy link
Contributor

@etobella We made a small change in order to solve the tests issue. Could you re-review, please? 🙏

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

etobella
etobella approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nitpicking comment,

The main idea of the change is that it is more readable

sale_delivery_state/models/sale_order_line.py Outdated Show resolved Hide resolved
@HaraldPanten
Copy link
Contributor

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-2845-by-HaraldPanten-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit aa0e325 into OCA:14.0 Dec 19, 2023
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4704eaa. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 14.0-imp-sale_delivery_state branch December 19, 2023 08:55
@HaraldPanten HaraldPanten mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentinVinagre ValentinVinagre ValentinVinagre approved these changes

@etobella etobella etobella approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@manuelregidor @HaraldPanten @OCA-git-bot @ValentinVinagre @etobella