Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] sale_order_product_recommendation_packaging_default: glue module #2723

Conversation

yajo
Copy link
Member

@yajo yajo commented Oct 13, 2023

This module extends the functionality of sale order product recommendations to support gathering and specifying product packaging and to allow you to input that info directly from the recommendations wizard.

To know how to use this module, follow the usage instructions of sale_order_product_recommendation.

If your database uses product packagings, you should be able to see and use 2 new columns in the recommendations wizard:

  • Packaging
  • Packaging Qty.

flameshot_2023-10-13_10-44

@moduon MT-3489

@yajo yajo self-assigned this Oct 13, 2023
@yajo yajo added this to the 16.0 milestone Oct 13, 2023
Copy link
Contributor

@Shide Shide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM (approved once tests will be fixed)

@yajo yajo force-pushed the 16.0-sale_order_product_recommendation_packaging_default branch from 77f00b3 to 34bee73 Compare October 16, 2023 10:28
@yajo
Copy link
Member Author

yajo commented Oct 16, 2023

Tests should be good now.

This module extends the functionality of sale order product recommendations to
support gathering and specifying product packaging and to allow you to input
that info directly from the recommendations wizard.

To know how to use this module, follow the usage instructions of `sale_order_product_recommendation`.

If your database uses product packagings, you should be able to see and use 2 new columns in the recommendations wizard:

- *Packaging*
- *Packaging Qty.*

@moduon MT-3489
@yajo yajo force-pushed the 16.0-sale_order_product_recommendation_packaging_default branch from 34bee73 to c9e15cc Compare October 16, 2023 12:04
@yajo
Copy link
Member Author

yajo commented Oct 16, 2023

note: runboat was failing because of #2725. I rebased this PR on top of 1ac7b24, which was the latest commit with a successful runboat, before merging #2513. It seems runboat resurrected now, so this can be reviewed functionally again.

@yajo yajo mentioned this pull request Oct 16, 2023
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review,

LGTM thank you @yajo

image

@yajo
Copy link
Member Author

yajo commented Oct 17, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2723-by-yajo-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e399a09 into OCA:16.0 Oct 17, 2023
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d3ef58c. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 16.0-sale_order_product_recommendation_packaging_default branch October 17, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants