Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] sale_cancel_reason #2400

Merged
merged 57 commits into from
Jul 12, 2023
Merged

[15.0][MIG] sale_cancel_reason #2400

merged 57 commits into from
Jul 12, 2023

Conversation

DavidJForgeFlow
Copy link
Contributor

Supersede #2178

Standard Migration to 15.0

@ForgeFlow

guewen and others added 30 commits March 6, 2023 11:54
@guewen @DavidJForgeFlow
[MRG] from master branch
d8da5f7 
(../trunk-generic/ rev 29.1.1)
@nbessi @DavidJForgeFlow
[FIX] sale cancel reason dependence
6117b5a 
(../trunk-generic/ rev 32.1.1)
@guewen @DavidJForgeFlow
[FIX] sale_cancel_reason: remove dependency on sale_stock
d8520bc 
(../trunk-generic/ rev 32.1.2)
@gurneyalex @DavidJForgeFlow
spellcheck
6f7b408
@eLBati @DavidJForgeFlow
[FIX] repository PEP8
b7af6a9
@eLBati @DavidJForgeFlow
[FIX] Still some PEP8 erros
442b219
@pedrobaeza @DavidJForgeFlow
- Set as uninstallable and moved to __unported__ dir all modules.
2c50529 
- Update travis.yml to 8.0
@yvaucher @DavidJForgeFlow
reactivate sale_cancel_reason
5100220
@yvaucher @DavidJForgeFlow
port models and method to api 8.0
97d6838
@yvaucher @DavidJForgeFlow
Improve override of cancel button to ease inheritance of view
cf9a4b0 
Only hide button instead of renaming it
@rdeheele @DavidJForgeFlow
[FIX] typo on class name
69d2983
@gurneyalex @DavidJForgeFlow
Add OCA as author of OCA addons
2a97506 
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
@mlaitinen @DavidJForgeFlow
Added Finnish translations
08d5bdf
@dhp-denero @DavidJForgeFlow
[FIX] cancel button of orignal view should be hide after installation…
8322032 
… of sale_cancel_reason module
@yvaucher @DavidJForgeFlow
Add missing default oca icons
605b1d7
@sysadminmatmoz @DavidJForgeFlow
Slovene translations added
7e8419a
@yvaucher @DavidJForgeFlow
bump version of sale_cancel_reason
73bc7ef
@oca-transbot @DavidJForgeFlow
OCA Transbot updated translations from Transifex
fd2e329
@pedrobaeza @DavidJForgeFlow
[MIG] Make modules uninstallable
4dc4a24
@sbidoul @DavidJForgeFlow
[FIX] remove en.po that was erroneously created by transbot
b1062d3
@pedrobaeza @DavidJForgeFlow
[MIG] Rename manifest files
e86b806
@kittiu @DavidJForgeFlow
[MIG] sale_cancel_reason Migration to 10.0 (OCA#477)
a2505dc 
* [MIG] sale_cancel_reason Migration to 10.0

* Follow coding standard

* Convert test to unittest2
@sbidoul @DavidJForgeFlow
remove obsolete .pot files [ci skip]
347d968
@oca-travis @DavidJForgeFlow
[UPD] Update sale_cancel_reason.pot
5cc4e6d
@oca-transbot @DavidJForgeFlow
Update translation files
93705da 
Updated by Actualizar ficheiros PO com o novo POT (msgmerge) hook in Weblate.
@pedrocasi @DavidJForgeFlow
Translated using Weblate (Portuguese)
5c368ad 
Currently translated at 100.0% (23 of 23 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_cancel_reason
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_cancel_reason/pt/
@DavidJForgeFlow
[MIG] sale_cancel_reason: Migration to 12.0
1581ff7
@OCA-git-bot @DavidJForgeFlow
[UPD] README.rst
4858fe3
@oca-travis @DavidJForgeFlow
[UPD] Update sale_cancel_reason.pot
b80777d
@oca-transbot @DavidJForgeFlow
Update translation files
5f80b7e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_cancel_reason
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_cancel_reason/
@DavidJForgeFlow
Copy link
Contributor Author

The tests not working are from another modules trying to cancel a Sale Order. With this module a wizard is showed when trying to cancel a sale order, so a simple so.button_cancel() in a test doesn't work anymore. That's why the other modules tests are not working.

@yaazkal yaazkal mentioned this pull request Mar 9, 2023
Open
@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration sale_cancel_reason

@rousseldenis
Copy link
Sponsor Contributor

@DavidJForgeFlow A better way of implementing this is to add a configuration parameter to activate or not the cancel reason (e.g.: on company level).

This allows this module coexist with other that use the cancel flow too and tests passing

@rousseldenis
Copy link
Sponsor Contributor

@ao-landoo Do you mind if we switch to this instead your PR?

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Apr 20, 2023
@OCA-git-bot
Copy link
Contributor

The migration issue (#1741) has been updated to reference the current pull request.
however, a previous pull request was referenced : #2178.
Perhaps you should check that there is no duplicate work.
CC : @ao-landoo

@DavidJForgeFlow
Copy link
Contributor Author

@DavidJForgeFlow A better way of implementing this is to add a configuration parameter to activate or not the cancel reason (e.g.: on company level).

This allows this module coexist with other that use the cancel flow too and tests passing

Hi @rousseldenis, I've commited a solution like you said. Thanks!

rousseldenis
rousseldenis approved these changes May 3, 2023
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@yaazkal
Copy link

yaazkal commented Jun 19, 2023

Hello, is there any ETA for this to be merged?

@dreispt dreispt mentioned this pull request Jul 12, 2023
Closed
@dreispt
Copy link
Sponsor Member

dreispt commented Jul 12, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-2400-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 12, 2023
@OCA-git-bot
Merge PR #2400 into 15.0
deae503 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 15.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 15.0-ocabot-merge-pr-2400-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ae02ec1 into OCA:15.0 Jul 12, 2023
7 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cd03d08. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theangryangel theangryangel theangryangel approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

None yet