Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] sale_order_revision #2381

Merged
merged 30 commits into from
May 8, 2023

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented Feb 17, 2023

Followup of #2275

  • Renamed test_requirements
  • removed oca_requirements
  • squashed commits

@simahawk @grindtildeath @cyrilmanuel @leemannd

rvalyi and others added 30 commits November 23, 2022 10:03
* extract description from __openerp__.py
* move things according to standard OCA layout
* reformatting
* port to new API
* Major rewrite of the 7.0 version:

  * the name of the SO is kept, and a revision number is appended
  * old revisions are made inactive
  * rewrite the copy logic

* update translations, added en.po fr.po
* fix typo in README
* use post_init_hook
* more assertions in the test
* sale_order_revision: remove en.po
* current_revision is only visible for non current revisions
* Fix create revision and improve view invisibility
* Fix unrevisioned name and improve test
wrong keyword name in SaleOrder.copy definition
was breaking sale order duplication
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_revision
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_revision/
Currently translated at 100.0% (14 of 14 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_revision
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_revision/de/
Currently translated at 100.0% (14 of 14 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_revision
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_revision/zh_CN/
Currently translated at 100.0% (14 of 14 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_revision
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_revision/es/
[13.0] fix pre-commit + formatting

add test lines and linting xml
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_revision
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_revision/
@OCA-git-bot
Copy link
Contributor

Hi @OriolVForgeFlow,
some modules you are maintaining are being modified, check this out!

@CRogos CRogos marked this pull request as ready for review February 17, 2023 15:00
@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration sale_order_revision

@OCA-git-bot
Copy link
Contributor

The migration issue (#1741) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1931.
Perhaps you should check that there is no duplicate work.
CC : @jwaes

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@CRogos
Copy link
Contributor Author

CRogos commented May 8, 2023

@pedrobaeza can you merge this?

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-2381-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 8, 2023
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 15.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 15.0-ocabot-merge-pr-2381-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 005ee2a into OCA:15.0 May 8, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7cd3a76. Thanks a lot for contributing to OCA. ❤️

@CRogos CRogos deleted the 15.0-mig-sale_order_revision branch May 8, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet