Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] product_supplierinfo_for_customer_sale #2083

Merged

Conversation

JuanyDForgeflow
Copy link

Based on product_supplierinfo_for_customer, this module loads in every sale order the
customer code defined in the product and allows use the product codes and product name
configured in each products in sale orders.

If you use Advanced price rules with formulas to define your pricing, and
choose that the price should be calculated from the partner prices in the
product form, the quantity in the sales order will be proposed from
the minimum quantity defined in the customerinfo.

@JuanyDForgeflow JuanyDForgeflow force-pushed the 15.0-mig-product_supplierinfo_for_customer_sale branch from 0147761 to b03f276 Compare June 20, 2022 14:05
Comment on lines 1 to 2
# Copyright 2017 Eficent Business and IT Consulting Services S.L.
# (http://www.eficent.com)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ForgeFlow

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
{
"name": "Product Supplierinfo for Customer Sale",
"version": "15.0.1.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "15.0.1.0.1",
"version": "15.0.1.0.0",

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@JuanyDForgeflow JuanyDForgeflow force-pushed the 15.0-mig-product_supplierinfo_for_customer_sale branch from b03f276 to 78b34e7 Compare July 6, 2022 12:40
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sergio-teruel
Copy link
Contributor

@JuanyDForgeflow Can you add this commit 53997ac

Thanks!!

AaronHForgeFlow and others added 21 commits September 2, 2022 07:25
[REF] product_supplierinfo_for_customer_sale: Changes in test.

[REF] product_supplierinfo_for_customer_sale: Complete README.rst
…rch, products found by default code and customer code

[REF] product_supplierinfo_for_customer_sale: Add test to find more than one product in name_search

[REF] product_supplierinfo_for_customer_sale: In test find one product from customer code and other one from product default code.

[REF] product_supplierinfo_for_customer_sale: Changes in name_search to work exactly with number of limit defined.

[REF] product_supplierinfo_for_customer_sale: Changes in name_search
 - New field name from type to supplierinfo_type
 - Remove copyright for __init__.py
 - Re-using variables from tests
 - Manifest bump version and using module url
 - Get commit history from
 https://github.com/OCA/product-attribute/tree/8.0/product_supplierinfo_for_customer_sale
    - Run 2to3 script
    - view fixing
… instead of manual assign.

 - Removing duplicated test for name_search
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
There's no price computation on the module, so there shouldn't be any test regarding
this topic, or it can fail in integration tests.
Currently translated at 11.1% (1 of 9 strings)

Translation: sale-workflow-11.0/sale-workflow-11.0-product_supplierinfo_for_customer_sale
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-product_supplierinfo_for_customer_sale/de/
LoisRForgeFlow and others added 16 commits September 2, 2022 07:25
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-product_supplierinfo_for_customer_sale
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-product_supplierinfo_for_customer_sale/it/
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-product_supplierinfo_for_customer_sale
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-product_supplierinfo_for_customer_sale/it/
@JuanyDForgeflow JuanyDForgeflow force-pushed the 15.0-mig-product_supplierinfo_for_customer_sale branch from 78b34e7 to 2d6c4a3 Compare September 2, 2022 12:27
@JuanyDForgeflow
Copy link
Author

@sergio-teruel I added the commit. Thanks

@pedrobaeza
Copy link
Member

/ocabot migration product_supplierinfo_for_customer_sale
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Sep 2, 2022
@OCA-git-bot
Copy link
Contributor

The migration issue (#1741) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1910.
Perhaps you should check that there is no duplicate work.
CC : @bizzappdev

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-2083-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fd1823b into OCA:15.0 Sep 2, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0b4ccd4. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 15.0-mig-product_supplierinfo_for_customer_sale branch September 5, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet