Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] sale_order_lot_selection #1752

Closed

Conversation

bizzappdev
Copy link
Contributor

@bizzappdev bizzappdev commented Oct 26, 2021

hurrinico and others added 30 commits October 25, 2021 19:52
[FIX] Fix product_id on test

[FIX] Fix product on test
[FIX] Use product_14 instead of product_11

[FIX] Add test's flow step
[FIX] change data in quant search

[FIX] Fixed tab

[FIX] Add check on lots list

FIX product_id_change_with_wh
Because quants_get_prefered_domain does not return quants with our lots, if other quants are available
Steps to reproduce:

1.- Create a new Sale Order with 2 or more lines of products
2.- Assign lot to every line (ensure lot has stock available)
3.- Confirm the Sale Order
4.- Go to the Delivery Order

Result:

Only the first line in the Delivery Order is in state "Available" and reserved, the rest of the lines are in state "Waiting Availability" and not reserved
@bizzappdev
Copy link
Contributor Author

@pedrobaeza the new workflow for test isnt supporting oca_dependencies.txt
I have added proper things. still it is not able to find the dependent module.

ERROR: Could not find a version that satisfies the requirement odoo-addon-stock_restrict_lot<15.1dev,>=15.0dev (from versions: none)

@pedrobaeza
Copy link
Member

You have to ask @sbidoul about the pip CI flow.

@sbidoul
Copy link
Member

sbidoul commented Oct 28, 2021

For referencing unmerged PRs, create a file named test-requirements.txt pointing to the python project of the unmerged addon, i.e. odoo-addon-stock_restrict_lot @ git+https://github.com/oca/{repo}@refs/pull/{pr}/head#subdirectory=setup/stock_restrict_lot.

You'll get used to it too, Pedro ;)

@bizzappdev
Copy link
Contributor Author

For referencing unmerged PRs, create a file named test-requirements.txt pointing to the python project of the unmerged addon, i.e. odoo-addon-stock_restrict_lot @ git+https://github.com/oca/{repo}@refs/pull/{pr}/head#subdirectory=setup/stock_restrict_lot.

You'll get used to it too, Pedro ;)

Thank you so much. it worked. :)

@bizzappdev
Copy link
Contributor Author

OCA/stock-logistics-workflow#921 has been merged so this can also proceed for review and merge
@dreispt

@nicomacr
Copy link
Contributor

@bizzappdev could you made a rebase for this PR?

@mcassuto
Copy link

@dreispt Dependency has been merged

@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration sale_order_lot_selection

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jun 22, 2023
@OCA-git-bot
Copy link
Contributor

The migration issue (#1741) has not been updated to reference the current pull request because a previous pull request (#2207) is not closed.
Perhaps you should check that there is no duplicate work.
CC @nicomacr

@rousseldenis
Copy link
Sponsor Contributor

rousseldenis commented Jun 22, 2023

@bizzappdev Do you mind if we switch to #2207 ?

Copy link

github-actions bot commented Nov 5, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 5, 2023
@mcassuto
Copy link

mcassuto commented Nov 5, 2023

There is already a PR for this module:
#2207

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 12, 2023
@rousseldenis
Copy link
Sponsor Contributor

@bizzappdev Do you mind if we switch to #2207 ?

@bizzappdev
Copy link
Contributor Author

@bizzappdev Do you mind if we switch to #2207 ?

feel free to proceed further :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet