Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[16.0] fastapi: optionally authenticated partner" #433

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

lmignon
Copy link
Sponsor Contributor

@lmignon lmignon commented May 3, 2024

Reverts #387

@sbidoul
Copy link
Member

sbidoul commented May 26, 2024

@lmignon do you want to merge this according to #387 (comment)

@lmignon
Copy link
Sponsor Contributor Author

lmignon commented May 27, 2024

@sbidoul I still have to think about it. The problem is not so trivial. Even if you declare the partner_id parameter as optional using type annotations, the implementation of the chosen method won't be aware of this annotation, which means that it will fail in the case of auth_jwt, for example, because it won't have found a token. Despite everything, I'm not comfortable with the proposed approach because I feel like I'm missing something. If I don't find another solution, the current code makes sense. If not, this PR could be merged with an explanation of how to cover this use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants