[14.0] [IMP] base_rest: support multiple types #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lmignon, |
lmignon
requested changes
Feb 15, 2024
There was a problem hiding this comment.
@renda-dev Thank you for the improment. Can you fix the tests plz?
renda-dev
force-pushed
the
14.0-imp-base_rest
branch
from
3df70f2
to
f50cc3c
Compare
Greetings, Is it possible to keep going with this PR anyway? @lmignon |
|
It's my understanding that #417 is required for this PR's tests to pass, is that correct? |
|
@renda-dev #417 is on its path to be merged. Once merged can you rebase your PR to make it 🟢 |
renda-dev
force-pushed
the
14.0-imp-base_rest
branch
from
f50cc3c
to
52a8366
Compare
Done, thanks! @lmignon |
lmignon
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal for this PR is to add multi-type support when generating swagger docs.
At the current state, even tho cerberus validator supports multi-type validation, swagger would raise an error without giving access to the api's docs.
To do so, I've also updated Swagger UI and OpenAPI to the LTS.
Depends on #417