Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] Update project template #394

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Open

Conversation

lmignon
Copy link
Sponsor Contributor

@lmignon lmignon commented Nov 7, 2023

  • Uses ruff to check and format code
  • Uses pyproject.toml files in addition to the setup directory

@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@lmignon lmignon force-pushed the 16.0-update-copier branch 6 times, most recently from 1bc513d to 9c64bf4 Compare November 7, 2023 14:20
@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Nov 13, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-394-by-lmignon-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 13, 2023
Signed-off-by lmignon
@OCA-git-bot
Copy link
Contributor

@lmignon The merge process could not be finalized, because command /tmp/tmpxs3yqwv4/bin/python -m build --wheel --outdir /tmp/tmp57pc8dqk --no-isolation failed with output:

Could not import runpy module
Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 14, in <module>
    import importlib.machinery # importlib first so we can test #15386 via -m
  File "/usr/lib/python3.8/importlib/__init__.py", line 57, in <module>
    import types
  File "/tmp/tmphocqur8f/graphql_base/types.py", line 4, in <module>
    import graphene
ModuleNotFoundError: No module named 'graphene'

@sbidoul
Copy link
Member

sbidoul commented Nov 13, 2023

Weird error. I'll look into this.

@sbidoul
Copy link
Member

sbidoul commented Nov 13, 2023

It's a PYTHONPATH issue creating confusion because import types unexpectedly imports types.py at the root of the graphql_base addon. I'll investigate. It might be a bug in build, not sure.

@sbidoul
Copy link
Member

sbidoul commented Nov 14, 2023

Should be fixed when OCA/oca-github-bot#270 is deployed.

@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Nov 14, 2023

Should be fixed when OCA/oca-github-bot#270 is deployed.

great! Thank you.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 17, 2024
switch to ruff into pre-commit
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants