[14.0][MIG] maintenance_stock: Migration to 14.0 #347

Reyes4711-S73 · 2023-07-06T06:24:06Z

Standard migration to 14.0

dalonsod · 2023-07-06T06:28:54Z

Hello @Reyes4711-S73 your PR is based on #337 , isn't it?

Please check, because that PR has new adjustments since you've cloned it

Reyes4711-S73 · 2023-07-06T06:42:50Z

@dalonsod I added your last changes in my migration PR

dalonsod · 2023-07-06T17:05:15Z

Please check errors in tests

mamcode · 2023-07-09T18:07:40Z

maintenance_stock/data/demo_maintenance_stock.xml

+        </function>
+        <function model="stock.inventory" name="action_validate">
+            <function
+                eval="[[('state','=','draft'),('id', '=', ref('maintenance_stock.stock_inventory_toner'))]]"


The inventory for demo product is In Progress when installing the module:

Perhaps it is this line that does not allow validating the inventory. Maybe the state at this moment is confirm (not tested).

Suggested change

eval="[[('state','=','draft'),('id', '=', ref('maintenance_stock.stock_inventory_toner'))]]"

eval="[[('state','=','confirm'),('id', '=', ref('maintenance_stock.stock_inventory_toner'))]]"

Can you review please ?

dalonsod · 2023-07-11T18:13:11Z

@Reyes4711-S73 I've still found some issues in commit history:

Your migration commit has some changes that are already made in current v13 migration commit. That's because you your commit history is still created from an old version. Please check.
Pre-commit stuff commit has adjustments in test file that shouldn't belong to that commit. If fix in tests are needed, please place them in migration commit.

Currently translated at 96.7% (29 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_stock Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/es/

Currently translated at 100.0% (30 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_stock Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/pt_BR/

Currently translated at 100.0% (30 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_stock Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/it/

Reyes4711-S73 · 2023-08-16T08:22:38Z

@mamcode @dalonsod I added the merged commit and solved some issues. Please, review it

mamcode

Hello @Reyes4711-S73 Thanks for the applied fixes.

Only a comment about the value used for field delivery_steps in stock.warehouse can you review please.

maintenance_stock/data/demo_maintenance_stock.xml

Reyes4711-S73 · 2023-09-04T08:30:36Z

@mamcode Change done

mamcode

Hello @Reyes4711-S73 thanks, but there are still some smaller details to fix.

maintenance_stock/data/demo_maintenance_stock.xml

Reyes4711-S73 · 2023-09-18T06:47:02Z

@mamcode done

mamcode

Thanks @Reyes4711-S73

mamcode · 2023-09-19T00:01:28Z

@dalonsod Can you check this PR again please?

dalonsod

Tested in runboat 👍 but see at code review required changes

maintenance_stock/models/maintenance_equipment.py

mamcode · 2023-09-24T14:18:49Z

@dalonsod @Reyes4711-S73 Hello, I see errors in the Odoo test job that seem to have nothing to do with the code of this PR, how can we run the jobs again?

dalonsod · 2023-09-25T06:58:26Z

Hello @mamcode , it's a known issue, please check odoo/odoo#122569 (comment)

github-actions · 2024-01-28T12:13:15Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

dalonsod · 2024-02-14T08:48:51Z

@etobella is this PR ready to be merged? Thanks!

etobella

I have a few questions before merging

etobella · 2024-02-14T08:55:28Z

maintenance_stock/models/stock_warehouse.py

-    def _get_locations_values(self, vals):
-        sub_locations = super()._get_locations_values(vals)
+    def _get_locations_values(self, vals, code=False):
+        sub_locations = super()._get_locations_values(vals, code)
        code = vals.get("code") or self.code


Is it this the same code provided by the inherited function?

Also, you are overriding a parameter of the function... you should review it.

@etobella you're right, that code was discussed in v13 here: #337 (review)

I've noticed two things:

v13 recommendation wasn't finally attended (code method parameter was finally unused), not fault of this PR.

commit history is definetely wrong, because this change shouldn't appear here.

@Reyes4711-S73 please rebuild commit history. See e.g.a7fa359#diff-6f3891aa1e983a123b23df8d101c909e1d2e6812915e7dbda2a820400a25c8b0 , that commit does not belong to v13 implementation and have merge conflicts syntax indeed. You should start again the migration process and strictly add needed changes in last Migration to 14.0 commit.

@etobella sorry I didn't notice that problem...

etobella · 2024-02-14T08:58:09Z

maintenance_stock/tests/test_maintenance_stock.py

@@ -173,11 +137,12 @@ def test_picking(self):
            ("product_id", "=", self.product1.id),
            ("location_id", "=", self.maintenance_warehouse.wh_cons_loc_id.id),
        ]
-        self.assertEqual(stock_quant_obj.search(domain_from).quantity, 0)
+        self.assertEqual(stock_quant_obj.search(domain_from).quantity, 5)


Why now it is 5 and before it was 0?

OCA-git-bot · 2024-02-14T08:59:27Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2024-02-14T08:59:27Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

mamcode · 2024-03-18T22:46:42Z

maintenance_stock/tests/test_maintenance_stock.py

+            {
+                "name": "Test equipment",
+                "allow_consumptions": True,
+                "equipment_assign_to": "employee",


Suggested change

"equipment_assign_to": "employee",

@Reyes4711-S73 @dalonsod @etobella
I think this field equipment_assign_to should be removed to avoid the dependence of hr_maintenance.

Everything else looks very good.

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch from edb1746 to 78728b3 Compare July 6, 2023 06:42

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch from 78728b3 to f20543b Compare July 6, 2023 07:04

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch from f20543b to bc0a774 Compare July 7, 2023 06:22

mamcode reviewed Jul 9, 2023

View reviewed changes

dalonsod and others added 13 commits August 16, 2023 09:23

[ADD] maintenance_stock

a727b8f

[UPD] Update maintenance_stock.pot

11a284e

[ADD] icon.png

657862d

Added translation using Weblate (Spanish)

d53885b

Translated using Weblate (Spanish)

f68a1d6

Currently translated at 96.7% (29 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_stock Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/es/

Added translation using Weblate (Portuguese (Brazil))

59a0178

Translated using Weblate (Portuguese (Brazil))

a45d1a4

Currently translated at 100.0% (30 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_stock Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/pt_BR/

Added translation using Weblate (Italian)

375fe29

Translated using Weblate (Italian)

9dd25d3

Currently translated at 100.0% (30 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_stock Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/it/

Translated using Weblate (Italian)

7a22051

Currently translated at 100.0% (30 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_stock Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/it/

[IMP] maintenance_stock: pre-commit execution

ae29d7e

[MIG] maintenance_stock: Migration to 13.0

a7fa359

[IMP] maintenance_stock: black, isort, prettier

b6a5612

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch 6 times, most recently from c9e4180 to 3ee7028 Compare August 16, 2023 08:16

mamcode reviewed Sep 3, 2023

View reviewed changes

maintenance_stock/data/demo_maintenance_stock.xml Outdated Show resolved Hide resolved

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch from 3ee7028 to 117ae55 Compare September 4, 2023 08:25

mamcode suggested changes Sep 11, 2023

View reviewed changes

maintenance_stock/data/demo_maintenance_stock.xml Outdated Show resolved Hide resolved

maintenance_stock/data/demo_maintenance_stock.xml Outdated Show resolved Hide resolved

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch 2 times, most recently from 74ce106 to 3c453fe Compare September 18, 2023 06:43

mamcode approved these changes Sep 19, 2023

View reviewed changes

dalonsod suggested changes Sep 21, 2023

View reviewed changes

maintenance_stock/models/maintenance_equipment.py Outdated Show resolved Hide resolved

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch 2 times, most recently from 9efae1f to b573f37 Compare September 22, 2023 05:58

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch from b573f37 to 3ab39ac Compare September 25, 2023 05:59

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 28, 2024

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch from 3ab39ac to 7754dd7 Compare January 29, 2024 06:49

[MIG] maintenance_stock: Migration to 14.0

07b3541

Reyes4711-S73 force-pushed the 14.0-mig-maintenance_stock branch from 7754dd7 to 07b3541 Compare January 29, 2024 07:01

dalonsod approved these changes Feb 14, 2024

View reviewed changes

OCA-git-bot added the approved label Feb 14, 2024

etobella reviewed Feb 14, 2024

View reviewed changes

OCA-git-bot added the ready to merge label Feb 14, 2024

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 18, 2024

mamcode reviewed Mar 18, 2024

View reviewed changes

dreispt added the question label May 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][MIG] maintenance_stock: Migration to 14.0 #347

[14.0][MIG] maintenance_stock: Migration to 14.0 #347

Reyes4711-S73 commented Jul 6, 2023

dalonsod commented Jul 6, 2023

Reyes4711-S73 commented Jul 6, 2023

dalonsod commented Jul 6, 2023

mamcode Jul 9, 2023

dalonsod commented Jul 11, 2023

Reyes4711-S73 commented Aug 16, 2023

mamcode left a comment

Reyes4711-S73 commented Sep 4, 2023

mamcode left a comment

Reyes4711-S73 commented Sep 18, 2023

mamcode left a comment

mamcode commented Sep 19, 2023

dalonsod left a comment

mamcode commented Sep 24, 2023

dalonsod commented Sep 25, 2023

github-actions bot commented Jan 28, 2024

dalonsod commented Feb 14, 2024

etobella left a comment

etobella Feb 14, 2024

dalonsod Feb 14, 2024

etobella Feb 14, 2024

OCA-git-bot commented Feb 14, 2024

OCA-git-bot commented Feb 14, 2024

mamcode Mar 18, 2024

	eval="[[('state','=','draft'),('id', '=', ref('maintenance_stock.stock_inventory_toner'))]]"
	eval="[[('state','=','confirm'),('id', '=', ref('maintenance_stock.stock_inventory_toner'))]]"

[14.0][MIG] maintenance_stock: Migration to 14.0 #347

Are you sure you want to change the base?

[14.0][MIG] maintenance_stock: Migration to 14.0 #347

Conversation

Reyes4711-S73 commented Jul 6, 2023

dalonsod commented Jul 6, 2023

Reyes4711-S73 commented Jul 6, 2023

dalonsod commented Jul 6, 2023

mamcode Jul 9, 2023

Choose a reason for hiding this comment

dalonsod commented Jul 11, 2023

Reyes4711-S73 commented Aug 16, 2023

mamcode left a comment

Choose a reason for hiding this comment

Reyes4711-S73 commented Sep 4, 2023

mamcode left a comment

Choose a reason for hiding this comment

Reyes4711-S73 commented Sep 18, 2023

mamcode left a comment

Choose a reason for hiding this comment

mamcode commented Sep 19, 2023

dalonsod left a comment

Choose a reason for hiding this comment

mamcode commented Sep 24, 2023

dalonsod commented Sep 25, 2023

github-actions bot commented Jan 28, 2024

dalonsod commented Feb 14, 2024

etobella left a comment

Choose a reason for hiding this comment

etobella Feb 14, 2024

Choose a reason for hiding this comment

dalonsod Feb 14, 2024

Choose a reason for hiding this comment

etobella Feb 14, 2024

Choose a reason for hiding this comment

OCA-git-bot commented Feb 14, 2024

OCA-git-bot commented Feb 14, 2024

mamcode Mar 18, 2024

Choose a reason for hiding this comment