[14.0][FIX] fieldservice_account_analytic: Write correct value for customer_id

[michelerusti]

The value for customer_id was written with the wrong value as the order.location_id.customer_id points to a different value than the sale order that generates the fsm_order

Also, it was not written at creation

[OCA-git-bot]

Hi @brian10048, @bodedra, @osimallen,
some modules you are maintaining are being modified, check this out!

[max3903]

@michelerusti If you could set those fields in vals before calling super(), they would be set as part of the same transactions.

[michelerusti]

@michelerusti If you could set those fields in vals before calling super(), they would be set as part of the same transactions.

Yes, thanks for the advise
I've also removed the error assertion in test_fsm_stock_account.py because with this fix the user is set correctly

Let me know if there's anything else needed to do!

[max3903]

@michelerusti I meant something like this:

    def write(self, vals):
        if "customer_id" not in vals and not self.customer_id:
            vals.update({"customer_id": self.location_id.customer_id.id})
        res = super().write(vals)

[michelerusti]

@max3903 I've edited, me know if it's alright!

[max3903]

@michelerusti Same idea for this method

[max3903]

@michelerusti Same idea but it's a bit different: you need to search the sale order with vals.get("sale_id") to get partner_id first. 1 select and 1 insert is still better than 1 insert and 1 update.

[hparfr]

[fsm.order]customer_id is not in the dependencies.

[michelerusti]

I see...
Since the field is defined in fieldservice_accont_analytic, how would you consider the idea to add that module as a dependency?
Otherwise all this PR would loose meaning

Let me know if there is any different approach you would've preferred

[hparfr]

There is different approach here. The most two obvious are:

• you use fieldservice_sale then you may want to invoice based on the sale order (and use analytics from sale order lines)
• you use create orders directly so you don't have a sale, thanks to fieldservice_account_analytic, you invoice the fsm orders directly.

Do you use another approach ?

From a technical perspective, you can put your code in a new module like fieldservice_sale_analytic.

[michelerusti]

We create the sale order and let the fsm order be generated by fieldservice_sale .
The problem is the customer_id that results empty when it should be the same customer of the sale order

This means that customer_id should always be available to fieldervice_sale since otherwise it breaks the module and the options are re-difining customer_id or add the dependency of fieldservice_sale_analytic .

I see this as a bug since otherwise the customer_id is not automatically set.
Let me know your thoughts about it and how you think is best to proceed, or even if it's to be considered a bug at all!

[michelerusti]

From a technical perspective, you can put your code in a new module like fieldservice_sale_analytic.

do you think that for this approach it needs to be created a new module?

[hparfr]

If you use sale to generate the fsm order, you do not need customer_id. The order will be invoiced directly by the sale.

Why using fieldservice_analytic ?

[michelerusti]

If you use sale to generate the fsm order, you do not need customer_id.

@hparfr
And is this definitive or is it open to discussion? It may not be essential but I think that having the correct customer reference would be nice

[hparfr]

this should be inherit from here : https://github.com/OCA/field-service/blob/14.0/fieldservice_sale/models/sale_order.py#L67

[michelerusti]

Inherited... how?
Looking in the code, the method _prepare_fsm_values() is not called by the create() but from other methods like this one

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.