[16.0][FIX] ddmrp: Reduce the size of demand and supply charts #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we install ddmrp_chatter, the sheet size is reduced and charts are too wide. Reducing width it shows correctly with and without ddmrp_chatter.
|
Hi @JordiBForgeFlow, @LoisRForgeFlow, @ChrisOForgeFlow, |
LoisRForgeFlow
requested changes
Dec 18, 2023
There was a problem hiding this comment.
I think this is not the best fix, why 450? It works for your screen size, but I assume that just that. The proper fix would make it responsive in the width.
You could try to play with sizing_mode = "stretch_width". At the same time we would need to ensure a minimun width and that the demand chart goes below the supply one when the width is too small.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we install ddmrp_chatter, the sheet size is reduced and charts are too wide. Reducing width it shows correctly with and without ddmrp_chatter.
Before the fix:
After the fix:
