New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] crm_phonecall: Migration to 17.0 #540
base: 17.0
Are you sure you want to change the base?
Conversation
* crm_phonecall module (OCA#131) This module is the part extracted from Odoo v8 crm module from Odoo that allows to record phone calls. As it has been stripped off from Odoo v9, we add again the feature via this module. Migration scripts are also included to upgrade a v8 database via OpenUpgrade and don't lose your history. * [MIG] crm_phone_call: Migrated to 10.0 - FIX: Correct some lint errors * [MIG] crm_phone_call: Migrated to 10.0
…reated from phonecall2phonecall wizard.
Currently translated at 100.0% (150 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/es/
Currently translated at 86.0% (129 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/
…ve_id is not correct
Currently translated at 92.7% (139 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/
Currently translated at 98.0% (147 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/
Currently translated at 27.3% (41 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/
Currently translated at 41.3% (62 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-13.0/crm-13.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/
…bally from crm settings.
…change name to all groups for consistancy.
Currently translated at 98.7% (159 of 161 strings) Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/es/
Currently translated at 100.0% (161 of 161 strings) Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/it/
Currently translated at 71.4% (115 of 161 strings) Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/tr/
Currently translated at 100.0% (161 of 161 strings) Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/it/
Currently translated at 100.0% (161 of 161 strings) Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/it/
Currently translated at 100.0% (161 of 161 strings) Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/it/
Currently translated at 100.0% (161 of 161 strings) Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/it/
Currently translated at 100.0% (161 of 161 strings) Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/
Currently translated at 100.0% (155 of 155 strings) Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/it/
Currently translated at 100.0% (155 of 155 strings) Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/es/
Currently translated at 100.0% (155 of 155 strings) Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/
Currently translated at 100.0% (154 of 154 strings) Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/es_AR/
Currently translated at 100.0% (154 of 154 strings) Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/it/
Currently translated at 100.0% (154 of 154 strings) Translation: crm-16.0/crm-16.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/it/
Now you get it! Please check the rest of your pull requests with the same problem. Another thing: you don't need to close existing pull request. Just fix it locally with the same branch name, and then forced push the result to your remote. /ocabot migration crm_phonecall |
OK! Sorry for the mistakes |
04f244f
to
9e600d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you cleanup the commit history according to: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate
remove commits by oca-git-bot, ...
<field invisible="1" name="tag_ids" /> | ||
<field invisible="1" name="create_date" /> | ||
<field invisible="1" name="opportunity_id" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invisible -> column_invisible needs to be changed as well.
Also in other views.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix it! Please review @CRogos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you cleanup the commits as well?
The code changes LGTM, but did not test the addon in detail.
9e600d1
to
2a1dcf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well in runboat
Module migrated to version 17.0
cc https://github.com/APSL 149031
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review
Issue #525