Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] account_invoice_view_payment: Validate & View payments button #1702

Merged

Conversation

AaronHForgeFlow
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow commented Apr 15, 2024

It is creating as many payments as invoices and it was not reconciling the invoices.

The solution is to remove the Validate & View Payments button because the standard button "Create Payments" already returns the action to see the payments involved. The button is not needed anymore!

image

cc @ForgeFlow

creating as many payments as invoices and it was not reconciling
the invoices.
The solution is to remove the Validate & View Payments button because
the standard button "Create Payments" already returns the action
to see the payments involved
@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-fix-account_invoice_view_payment branch from 881bdf0 to 3a22a02 Compare April 19, 2024 15:01
Copy link

@PauBForgeFlow PauBForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow
Copy link
Contributor Author

I am merging this because "Validate & View Payment" is too buggy. Right now it is generating multiple payments when paying more than one invoice at a time. It should have been removed in the migration.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1702-by-AaronHForgeFlow-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fae452e into OCA:15.0 May 3, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a922649. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants