Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_invoice_discount_display_amount: Migration to 16.0 #1623

Merged
merged 10 commits into from
May 27, 2024
Merged

[16.0][MIG] account_invoice_discount_display_amount: Migration to 16.0 #1623

merged 10 commits into from
May 27, 2024

Conversation

samoros1
Copy link

@samoros1 samoros1 commented Dec 1, 2023

No description provided.

@samoros1
Copy link
Author

samoros1 commented Dec 1, 2023

Module migrated to version 16.0

cc https://github.com/APSL 148568

@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 please review

Issue #1250

@samoros1 samoros1 force-pushed the 16.0-mig-account_invoice_discount_display_amount branch from ed3d1e8 to e705c52 Compare December 1, 2023 15:45
@rafaelbn
Copy link
Member

rafaelbn commented Dec 2, 2023

/ocabot migration account_invoice_discount_display_amount

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 2, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 2, 2023
Open
60 tasks
rafaelbn
rafaelbn approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

imagen

miquelalzanillas
miquelalzanillas approved these changes Dec 4, 2023
View reviewed changes
Copy link

@miquelalzanillas miquelalzanillas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

peluko00
peluko00 approved these changes Dec 5, 2023
View reviewed changes
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AungKoKoLin1997
AungKoKoLin1997 approved these changes Jan 31, 2024
View reviewed changes
Copy link

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoniaViciana
Copy link

This PR has 5 reviewers and approvals, can it be merged?

Thanks,

@pedrobaeza

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1623-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 28, 2024
@OCA-git-bot
Merge PR #1623 into 16.0
5225281 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command twine check odoo_addon_account_invoice_discount_display_amount-16.0.1.0.0.2-py3-none-any.whl failed with output:

Checking 
odoo_addon_account_invoice_discount_display_amount-16.0.1.0.0.2-py3-none-any.whl
: �[31mFAILED�[0m
�[31mERROR   �[0m `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line 79: Warning: Bullet list ends without a blank line; unexpected    
         unindent.                                                              
�[33mWARNING �[0m `long_description_content_type` missing. defaulting to `text/x-rst`.

pedrobaeza
pedrobaeza previously requested changes Feb 28, 2024
View reviewed changes
account_invoice_discount_display_amount/readme/CONTRIBUTORS.rst Outdated
Comment on lines 3 to 4
- [APSL](https://apsl.tech):
- Santi Amorós \<<samoros@apsl.net>\>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect RST syntax. This is RST, not Markdown (you can convert all to MD, but not mix them, and more having .rst extension).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix it!

@SoniaViciana
Copy link

could you review to be able to merge @samoros1 ?
Thanks!

@peluko00 peluko00 force-pushed the 16.0-mig-account_invoice_discount_display_amount branch from e705c52 to 373cba7 Compare May 22, 2024 11:26
@peluko00
Copy link

could you review to be able to merge @samoros1 ? Thanks!

Done!

@aritzolea
Copy link

@pedrobaeza Could it be merged after the correction on Readme? Thanks

@pedrobaeza pedrobaeza dismissed their stale review May 27, 2024 09:15

README fix done

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1623-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit b64776d into OCA:16.0 May 27, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6396146. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peluko00 peluko00 peluko00 approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

@miquelalzanillas miquelalzanillas miquelalzanillas approved these changes

@AungKoKoLin1997 AungKoKoLin1997 AungKoKoLin1997 approved these changes

@aliciagaarzo aliciagaarzo aliciagaarzo approved these changes

@pedrobaeza pedrobaeza pedrobaeza left review comments

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet