Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] account move substate #1595

Open
wants to merge 7 commits into
base: 15.0
Choose a base branch
from
Open

[15.0][MIG] account move substate #1595

wants to merge 7 commits into from

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Nov 6, 2023

standard migration

@bosd bosd mentioned this pull request Nov 7, 2023
Merged
@bosd
Copy link
Contributor Author

bosd commented Nov 7, 2023

@Saran440 Can you please review this one as well?

@bosd
Copy link
Contributor Author

bosd commented Nov 11, 2023 •
edited

@Draynyel-bosd Can you please review?

@Saran440
Copy link
Member

@bosd I think we should review v14 first #1001
and after merged, you can rebase that you commit for improved code to v15
Selection_004

@bosd
Copy link
Contributor Author

bosd commented Nov 14, 2023

@bosd I think we should review v14 first #1001

Actually, that one is superseeded by #1594.
In the ideal world, yes, we would start on V14 and forward migrate it to 17.
However, client needed it on V16. So V16 is/was the priority.

The other versions / PR are bonus. added them, in case somebody wants to merge them.

Dranyel-Bosd
Dranyel-Bosd approved these changes Nov 14, 2023
View reviewed changes
Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

bofiltd
bofiltd approved these changes Nov 27, 2023
View reviewed changes
Copy link

@bofiltd bofiltd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bosd
Copy link
Contributor Author

bosd commented Apr 18, 2024

@etobella V16 is already merged. Can you please merge this one as well?

@etobella
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 15.0.

@OCA-git-bot OCA-git-bot force-pushed the 15.0-mig-account_move_substate branch from 407d82d to 81332a3 Compare April 18, 2024 07:47
etobella
etobella reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unable to test it using README on runboat. Can you review the readme please?

account_move_substate/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
@bosd bosd force-pushed the 15.0-mig-account_move_substate branch from 81332a3 to d83ab73 Compare April 27, 2024 18:51
@bosd bosd force-pushed the 15.0-mig-account_move_substate branch from d83ab73 to f7af089 Compare April 27, 2024 18:51
@bosd bosd mentioned this pull request Apr 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etobella etobella etobella left review comments

@bofiltd bofiltd bofiltd approved these changes

@Dranyel-Bosd Dranyel-Bosd Dranyel-Bosd approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bosd @Saran440 @OCA-git-bot @etobella @bofiltd @Dranyel-Bosd @ps-tubtim