[16.0] [MIG] account_invoice_tax_required #1259

ThomasBinsfeld · 2022-10-10T09:39:43Z

Currently translated at 100,0% (4 of 4 strings) Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_tax_required/es/

Currently translated at 100,0% (4 of 4 strings) Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_tax_required/de/

Using `invoice_validate` method for validating invoice, makes the call to the sequence to be done before, and although rollbacking the transaction, the next number is already assigned and then you may have gaps in your numbering. Thus, we do the check before this, on the first executed method.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_tax_required/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-15.0/account-invoicing-15.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_invoice_tax_required/

TT32113

Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-15.0/account-invoicing-15.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_invoice_tax_required/ca/

oca-clabot · 2022-10-10T09:39:46Z

Hey @ThomasBinsfeld, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

oca-ci oca-ci@odoo-community.org (no github login found)

Appreciation of efforts,
OCA CLAbot

adrienpeiffer · 2022-10-10T09:47:09Z

account_invoice_tax_required/tests/test_account_move_tax_required.py

+            dict(
+                code="cust_acc",
+                name="customer account",
+                user_type_id=account_user_type.id,


Suggested change

user_type_id=account_user_type.id,

account_type="asset_receivable",

adrienpeiffer · 2022-10-10T09:47:46Z

account_invoice_tax_required/tests/test_account_move_tax_required.py

+                    "account_id": self.account_account.search(
+                        [
+                            (
+                                "user_type_id",


Suggested change

"user_type_id",

"account_type",

adrienpeiffer · 2022-10-10T09:48:07Z

account_invoice_tax_required/tests/test_account_move_tax_required.py

+                            (
+                                "user_type_id",
+                                "=",
+                                self.env.ref("account.data_account_type_revenue").id,


Suggested change

self.env.ref("account.data_account_type_revenue").id,

"income",

adrienpeiffer · 2022-10-10T09:49:56Z

/ocabot migration account_invoice_tax_required

adrienpeiffer

Test and Code review

AnizR

code LGTM

kittiu · 2022-10-11T09:10:40Z

/ocabot migration account_invoice_tax_required

@adrienpeiffer not related to this PR, I just miss this ocabot migration feature, can you guide where I can find info about this? Thanks! :)

adrienpeiffer · 2022-10-11T12:27:56Z

@kittiu https://github.com/OCA/oca-github-bot#readme

OCA-git-bot · 2022-10-15T10:00:04Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2022-10-15T10:24:55Z

/ocabot merge nobump

OCA-git-bot · 2022-10-15T10:25:18Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1259-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2022-10-15T10:30:20Z

Congratulations, your PR was merged at 35134d9. Thanks a lot for contributing to OCA. ❤️

Signed-off-by HaraldPanten

vrenaville and others added 30 commits October 10, 2022 11:21

account_invoice_tax_required

0b1ea13

remove deprecated code + add contributor + issue tracking

9725d6a

Tracker link

fd0c147

replace {} variable

0ded4fe

change error message

015f095

remove non related file

5a6cf95

version

6ab2cbf

Add missing default oca icons

f9a1620

OCA Transbot updated translations from Transifex

fd3fc01

prefix versions with 8.0

8c8bac1

Make modules uninstallable

b870ce1

remove en.po that was erroneously created by transbot

484c2d5

Rename manifest files

a5b9e3b

account_invoice_tax_required (OCA#404)

2d2a1ee

account_tax_invoice_required: Migrated to 10.0

a8c4f3a

account_invoice_tax_required: Migration to 11.0

f8f5271

account_invoice_tax_required: Licence and runbot changes

9df18f5

OCA Transbot updated translations from Transifex

7d4f857

OCA Transbot updated translations from Transifex

c29d98b

remove obsolete .pot files [ci skip]

7ffb9fb

Update account_invoice_tax_required.pot

392c119

[MIG] account_invoice_tax_required v11 to v12

1b1f718

[FIX] account_invoice_tax_required: Fix tests

4a02f08

[UPD] README.rst

f78ba15

[UPD] Update account_invoice_tax_required.pot

5cb1d36

[UPD] README.rst

14a28ed

oca-transbot and others added 4 commits October 10, 2022 11:21

[FIX] account_invoice_tax_required: fix tests

5ace177

TT32113

account_invoice_tax_required 15.0.1.0.1

532b85d

adrienpeiffer requested changes Oct 10, 2022

View reviewed changes

OCA deleted a comment from OCA-git-bot Oct 10, 2022

OCA-git-bot added this to the 16.0 milestone Oct 10, 2022

OCA-git-bot mentioned this pull request Oct 10, 2022

Migration to version 16.0 #1250

Open

60 tasks

[MIG] account_invoice_tax_required from 15.0 to 16.0

b1aa18c

ThomasBinsfeld force-pushed the 16.0-mig_account_invoice_tax_required_tbi branch from aeebfb8 to b1aa18c Compare October 10, 2022 09:52

adrienpeiffer approved these changes Oct 10, 2022

View reviewed changes

sbejaoui approved these changes Oct 10, 2022

View reviewed changes

OCA-git-bot added the approved label Oct 10, 2022

baimont approved these changes Oct 10, 2022

View reviewed changes

AnizR approved these changes Oct 10, 2022

View reviewed changes

apineux approved these changes Oct 11, 2022

View reviewed changes

OCA-git-bot added the ready to merge label Oct 15, 2022

OCA-git-bot added the bot is merging ⏳ label Oct 15, 2022

OCA-git-bot merged commit 3dbc298 into OCA:16.0 Oct 15, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 15, 2022

odooNextev pushed a commit to odooNextev/account-invoicing that referenced this pull request Sep 29, 2023

Merge PR OCA#1259 into 14.0

50a720e

Signed-off-by HaraldPanten

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0] [MIG] account_invoice_tax_required #1259

[16.0] [MIG] account_invoice_tax_required #1259

ThomasBinsfeld commented Oct 10, 2022

oca-clabot commented Oct 10, 2022

adrienpeiffer Oct 10, 2022

adrienpeiffer Oct 10, 2022

ThomasBinsfeld Oct 10, 2022

adrienpeiffer Oct 10, 2022

ThomasBinsfeld Oct 10, 2022

adrienpeiffer commented Oct 10, 2022

adrienpeiffer left a comment

AnizR left a comment

kittiu commented Oct 11, 2022 •

edited

adrienpeiffer commented Oct 11, 2022

OCA-git-bot commented Oct 15, 2022

pedrobaeza commented Oct 15, 2022

OCA-git-bot commented Oct 15, 2022

OCA-git-bot commented Oct 15, 2022

	user_type_id=account_user_type.id,
	account_type="asset_receivable",

	self.env.ref("account.data_account_type_revenue").id,
	"income",

[16.0] [MIG] account_invoice_tax_required #1259

[16.0] [MIG] account_invoice_tax_required #1259

Conversation

ThomasBinsfeld commented Oct 10, 2022

oca-clabot commented Oct 10, 2022

adrienpeiffer Oct 10, 2022

Choose a reason for hiding this comment

adrienpeiffer Oct 10, 2022

Choose a reason for hiding this comment

ThomasBinsfeld Oct 10, 2022

Choose a reason for hiding this comment

adrienpeiffer Oct 10, 2022

Choose a reason for hiding this comment

ThomasBinsfeld Oct 10, 2022

Choose a reason for hiding this comment

adrienpeiffer commented Oct 10, 2022

adrienpeiffer left a comment

Choose a reason for hiding this comment

AnizR left a comment

Choose a reason for hiding this comment

kittiu commented Oct 11, 2022 • edited

adrienpeiffer commented Oct 11, 2022

OCA-git-bot commented Oct 15, 2022

pedrobaeza commented Oct 15, 2022

OCA-git-bot commented Oct 15, 2022

OCA-git-bot commented Oct 15, 2022

kittiu commented Oct 11, 2022 •

edited