[FIX] sale_timesheet_invoice_description: Fix bug TID

Fix bug of setting Timesheet Invoice Description field as false by default or in the configuration and sales view Improve sale model allowing for a False situation of Timesheet Invoice Description
OCA · Apr 30, 2024 · 6352247 · 6352247
1 parent 1f08500
commit 6352247
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/sale_timesheet_invoice_description/models/res_config.py b/sale_timesheet_invoice_description/models/res_config.py
@@ -10,6 +10,7 @@ class ResConfigSettings(models.TransientModel):
         selection="_get_timesheet_invoice_description",
         string="Timesheet Invoice Description",
         default_model="sale.order",
+        default="000",
     )
 
     @api.model

diff --git a/sale_timesheet_invoice_description/models/sale.py b/sale_timesheet_invoice_description/models/sale.py
@@ -26,6 +26,8 @@ def _get_timesheet_invoice_description(self):
 
     def _get_timesheet_details(self, timesheet, desc_rule):
         details = []
+        if not desc_rule:
+            return details
         if desc_rule[0] == "1":
             details.append(fields.Date.to_string(timesheet.date))
         if desc_rule[1] == "1":

diff --git a/sale_timesheet_invoice_description/views/res_config_view.xml b/sale_timesheet_invoice_description/views/res_config_view.xml
@@ -17,7 +17,10 @@
                             Default timesheet details on invoice lines
                         </div>
                         <div class="text-muted">
-                            <field name="default_timesheet_invoice_description" />
+                            <field
+                                name="default_timesheet_invoice_description"
+                                required="1"
+                            />
                         </div>
                     </div>
                 </div>

diff --git a/sale_timesheet_invoice_description/views/sale_view.xml b/sale_timesheet_invoice_description/views/sale_view.xml
@@ -8,7 +8,7 @@
         <field name="inherit_id" ref="sale.view_order_form" />
         <field name="arch" type="xml">
             <field name="show_update_fpos" position="after">
-                <field name="timesheet_invoice_description" />
+                <field name="timesheet_invoice_description" required="1" />
                 <field name="timesheet_invoice_split" />
             </field>
         </field>