[17.0][OU-ADD] openupgrade_framework: framework patches #4327

acpMicrocom · 2024-02-28T18:56:54Z

No description provided.

legalsylvain

Thanks a lot for working on openupgrade V17.
Could you preserve git history, cherry picking previous commit present in V16 ?

it respects authors and history
it makes easier the diff review between 16.0 and 17.0

see : https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#technical-method-to-migrate-a-module-from-160-to-170-branch

Thanks !

/ocabot migration openupgrade_framework

acpMicrocom · 2024-02-28T20:03:44Z

Ok Thanks !

If we don't include it, /jsonrpc route doesn't work.

If you have a module in previous versions that adds data on a model, and such model is not loaded in the registry in current version because the module is absent in it, you can't uninstall such module, getting this error: File "odoo/odoo/addons/base/models/ir_model.py", line 1945, in _module_data_uninstall delete(self.env[model].browse(item[1] for item in items)) File "odoo/odoo/api.py", line 463, in __getitem__ return self.registry[model_name]._browse(self, (), ()) File "odoo/odoo/modules/registry.py", line 177, in __getitem__ return self.models[model_name] KeyError: 'model' With this patch, data cleanup of such model is skipped and there's no crash.

…ore ; add links to the new OpenUpgrade website

If corresponding field is None, we need to avoid the "AttributeError: 'NoneType' object has no attribute error.

…view_error

…rg validate as it is not anymore in odoo 15

…e useless after the input argument validate has been removed

Fixes: OCA#3285

and after the migration

legalsylvain

thanks !

pedrobaeza · 2024-02-29T08:13:12Z

@legalsylvain have you checked that each patch method is still the same? It's for not doing 2 times the same work.

legalsylvain · 2024-02-29T08:32:46Z

@legalsylvain have you checked that each patch method is still the same? It's for not doing 2 times the same work.

I just check that the function still exists, with the same arguments list.

StefanRijnhart · 2024-04-01T14:00:27Z

openupgrade_framework/odoo_patch/odoo/addons/base/models/ir_model.py

+@api.model
+def _process_end(self, modules):
+    """Don't warn about upgrade conventions from Odoo
+    ('fields should be explicitly removed by an upgrade script')


Warning was removed from Odoo in odoo/odoo#56657
This patch can be removed here.

StefanRijnhart · 2024-04-01T14:18:53Z

openupgrade_framework/odoo_patch/odoo/tests/loader.py

+def _get_tests_modules(mod):
+    """
+    Make odoo load tests from openupgrade_scripts/scripts/$module/$version/tests
+    instead of the standard location


It looks like https://github.com/odoo/odoo/blob/8c62f4a/odoo/tests/loader.py#L38-L57 makes it possible to load tests from upgrade paths, which is also the aim of this patch. Do you agree @hbrunn?

Played around with this a bit, and I got it to load a test from the --upgrade-path (subpath base/tests/test_migration_test.py). Because it has a module path in odoo.upgrade instead of odoo.addons it does not get assigned the expected attributes in https://github.com/odoo/odoo/blob/aa84ccf/odoo/tests/common.py#L222-L227. The attributes therefore have to be assigned manually:

from odoo.tests import tagged, TransactionCase @tagged("at_install", "openupgrade") class TestMigrationTest(TransactionCase): def test_migration_test(self): self.assertEqual(1, 0) TestMigrationTest.test_module = "base" TestMigrationTest.test_class = "TestMigrationTest" TestMigrationTest.test_sequence = 0

After that, the test runs fine and can be selected with test tags base:TestMigrationTest or openupgrade.

Personally, I think that is acceptable given that tests are still very much underused and not for the faint of heart at this point.

agreed the patch becomes obsolete in v17. We could provide a base class for running openupgrade tests, but that's for another PR

rvalyi · 2024-04-01T15:54:01Z

openupgrade_framework/readme/CREDITS.md

@@ -0,0 +1,4 @@
+Many developers have contributed to the OpenUpgrade framework in its
+previous incarnation. Their original contributions may no longer needed,


s/may no longer needed/may no longer be needed/

hi @rvalyi. I think you can use the "propose change" github feature. It is more readable than the regex syntax ! (and can be approved if desired).
thanks !

are you sure it can be used? It adds extra commits noise that many dislike. I don't see the feature used anymore in the OCA. Can you confirm it's easy enough to remove the commit noise vs doing it this way?

I don't use the github feature for committing myself, because indeed it creates extra commits I'd have to squash again. But still I appreciate reviewers using the feature, because that makes it perfectly clear what they mean.

But still I appreciate reviewers using the feature, because that makes it perfectly clear what they mean.

👍 That is my point. Regex expression is not very easy to read.

I don't use the github feature for committing myself, because indeed it creates extra commits I'd have to squash again

Matter of taste. Once the change proposal is done you can :

merge then squash

or make changes locally and push

StefanRijnhart · 2024-04-26T10:11:21Z

@iTecan There are no migration scripts yet for OpenUpgrade 17. These are only the supporting framework methods.

StefanRijnhart · 2024-04-26T10:11:58Z

@acpMicrocom The pandoc-3.1.12.1-1-amd64.deb is an artifact of pre-commit initialization. Please remove it from this PR. Can you follow-up the other comments?

MiquelRForgeFlow · 2024-05-22T08:39:04Z

@StefanRijnhart would you like to supersede this PR?

StefanRijnhart · 2024-05-23T05:17:51Z

Superseded by #4427

-This commit remove unecessary patch -Check if test exist then execute it in the test.yml -Remove the test loader from patch, detail at OCA#4327 (comment)

parent c973596 author 张飞虎 <feihu.zhang@yumtown.com.cn> 1711431231 +0000 committer 张飞虎 <feihu.zhang@yumtown.com.cn> 1717058855 +0000 # This is a combination of 2 commits. # This is the 1st commit message: parent c973596 author 张飞虎 <feihu.zhang@yumtown.com.cn> 1711431231 +0000 committer 张飞虎 <feihu.zhang@yumtown.com.cn> 1717058818 +0000 添加openupgrade_framework代码OCA#4327 增加upgrade_anaylysis_work.txt init base migration script 初步完成base模块的升级脚本初步添加account模块升级脚本修复文件名错误 BUG Fix 增加mail模块升级脚本完成mail升级脚本初步添加hr升级脚本完成hr模块升级脚本 # This is the commit message OCA#2: 完成account模块升级脚本 # This is the commit message OCA#3: 更新模块清单 # This is the commit message OCA#4: 添加sale_management升级脚本 # This is the commit message OCA#5: 修复升级问题 # This is the commit message OCA#6: 完善project模块升级脚本 # This is the commit message OCA#7: 增加一堆模块no_update的处理 # This is the commit message OCA#8: BUG Fix # This is the commit message OCA#9: 暂时移除delivery升级脚本 # This is the commit message OCA#10: 改进项目升级脚本 # This is the commit message OCA#11: 添加针对hr_responsible_id字段的处理 # This is the commit message OCA#12: 增加auth_signup升级脚本 # This is the commit message OCA#13: 修复mail_alias上的mail_channel数据

parent c973596 author 张飞虎 <feihu.zhang@yumtown.com.cn> 1711431231 +0000 committer 张飞虎 <feihu.zhang@yumtown.com.cn> 1717058855 +0000 parent c973596 author 张飞虎 <feihu.zhang@yumtown.com.cn> 1711431231 +0000 committer 张飞虎 <feihu.zhang@yumtown.com.cn> 1717058818 +0000 添加openupgrade_framework代码OCA#4327 增加upgrade_anaylysis_work.txt init base migration script 初步完成base模块的升级脚本初步添加account模块升级脚本修复文件名错误 BUG Fix 增加mail模块升级脚本完成mail升级脚本初步添加hr升级脚本完成hr模块升级脚本完成account模块升级脚本更新模块清单添加sale_management升级脚本修复升级问题完善project模块升级脚本增加一堆模块no_update的处理 BUG Fix 暂时移除delivery升级脚本改进项目升级脚本添加针对hr_responsible_id字段的处理增加auth_signup升级脚本修复mail_alias上的mail_channel数据

parent c973596 author 张飞虎 <feihu.zhang@yumtown.com.cn> 1711431231 +0000 committer 张飞虎 <feihu.zhang@yumtown.com.cn> 1717058855 +0000 parent c973596 author 张飞虎 <feihu.zhang@yumtown.com.cn> 1711431231 +0000 committer 张飞虎 <feihu.zhang@yumtown.com.cn> 1717058818 +0000 添加openupgrade_framework代码OCA#4327 增加upgrade_anaylysis_work.txt init base migration script 初步完成base模块的升级脚本初步添加account模块升级脚本修复文件名错误 BUG Fix 增加mail模块升级脚本完成mail升级脚本初步添加hr升级脚本完成hr模块升级脚本完成account模块升级脚本更新模块清单添加sale_management升级脚本修复升级问题完善project模块升级脚本增加一堆模块no_update的处理 BUG Fix 暂时移除delivery升级脚本改进项目升级脚本添加针对hr_responsible_id字段的处理增加auth_signup升级脚本修复mail_alias上的mail_channel数据添加openupgrade_framework代码OCA#4327 parent c973596 author 张飞虎 <feihu.zhang@yumtown.com.cn> 1711431231 +0000 committer 张飞虎 <feihu.zhang@yumtown.com.cn> 1717058855 +0000 parent c973596 author 张飞虎 <feihu.zhang@yumtown.com.cn> 1711431231 +0000 committer 张飞虎 <feihu.zhang@yumtown.com.cn> 1717058818 +0000 添加openupgrade_framework代码OCA#4327 增加upgrade_anaylysis_work.txt init base migration script 初步完成base模块的升级脚本初步添加account模块升级脚本修复文件名错误 BUG Fix 增加mail模块升级脚本完成mail升级脚本初步添加hr升级脚本完成hr模块升级脚本完成account模块升级脚本更新模块清单添加sale_management升级脚本修复升级问题完善project模块升级脚本增加一堆模块no_update的处理 BUG Fix 暂时移除delivery升级脚本改进项目升级脚本添加针对hr_responsible_id字段的处理增加auth_signup升级脚本修复mail_alias上的mail_channel数据

legalsylvain requested changes Feb 28, 2024

View reviewed changes

OCA-git-bot added this to the 17.0 milestone Feb 28, 2024

OCA-git-bot mentioned this pull request Feb 28, 2024

Migration to version 17.0 #4124

Open

4 tasks

legalsylvain and others added 26 commits February 28, 2024 16:27

[INIT] Full refactor of the OpenUpgrade project

7145adf

[DEL] openupgrade_records -> server-tools/14.0

8683fd9

[RFR] OpenUpgrade framework patches

ae78c24

[UPD] README.rst

c9472e0

[ADD] icon.png

44d8f2f

[FIX] _logger.warn -> _logger.warning

735492b

[FIX] doc: base must be included in --load parameter

c2d6588

If we don't include it, /jsonrpc route doesn't work.

[UPD] README.rst

1d6b423

[FIX] openupgrade_framework: _drop_column was in wrong class

8ae6847

[DOC] add banner file, to make this module more visible on the app st…

49501e8

…ore ; add links to the new OpenUpgrade website

[UPD] README.rst

5a8ef1c

[FIX] Don't break on missing model in selection _process_ondelete

2d6018d

[REF] Add maintainers

826366a

[UPD] README.rst

a2686cf

[IMP] openupgrade_framework: avoid AttributeError in view validation

21d49aa

If corresponding field is None, we need to avoid the "AttributeError: 'NoneType' object has no attribute error.

[MIG][15.0] openupgrade_framework

789b40f

[REF] adapt framework, due to renaming handle_view_error into _raise_…

add83ab

…view_error

fixup! [WIP][15.0] base module

357568b

fixup! fixup! [WIP][15.0] base module

01920f7

Update method _postprocess_view of ir_ui_view by removing the input a…

8f8a282

…rg validate as it is not anymore in odoo 15

[MIG] remove the odoo_patch on function _postprocess_view which becam…

725e2e1

…e useless after the input argument validate has been removed

Adjustements for code style

9dfda1b

[UPD] README.rst

9f18f92

[OU-FIX] Migration scripts were not run during install

5876638

Fixes: OCA#3285

[IMP] openupgrade_framework: tracking number of rows per table before

681da28

and after the migration

OCA-git-bot and others added 5 commits February 28, 2024 16:27

[UPD] README.rst

e5b22e2

[FIX] Add openupgradelib dependencies in manifest files

7fed531

[UPD] README.rst

49566f5

[OU-FIX] don't fail when there's an unknown field in a view

d09a9a6

[IMP] openupgrade_framework: pre-commit auto fixes

08ae911

acpMicrocom force-pushed the 17.0_UO_frameworks branch from ff25457 to 61ac302 Compare February 28, 2024 22:00

[MIG] openupgrade_framework: Migration to 17.0

e104cf7

acpMicrocom force-pushed the 17.0_UO_frameworks branch from 61ac302 to e104cf7 Compare February 28, 2024 22:03

legalsylvain approved these changes Feb 28, 2024

View reviewed changes

xtanuiha pushed a commit to xtanuiha/OpenUpgrade that referenced this pull request Mar 27, 2024

添加openupgrade_framework代码OCA#4327

49cc460

StefanRijnhart requested changes Apr 1, 2024

View reviewed changes

rvalyi reviewed Apr 1, 2024

View reviewed changes

pedrobaeza changed the title ~~[OU-ADD] openupgrade_framework: framework patches~~ [17.0][OU-ADD] openupgrade_framework: framework patches Apr 11, 2024

pedrobaeza mentioned this pull request May 15, 2024

[MIG] openupgrade_framework, base v17 #4427

Merged

2 tasks

StefanRijnhart closed this May 23, 2024

xtanuiha pushed a commit to xtanuiha/OpenUpgrade that referenced this pull request May 30, 2024

添加openupgrade_framework代码OCA#4327

c973596

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][OU-ADD] openupgrade_framework: framework patches #4327

[17.0][OU-ADD] openupgrade_framework: framework patches #4327

acpMicrocom commented Feb 28, 2024

legalsylvain left a comment

acpMicrocom commented Feb 28, 2024

legalsylvain left a comment

pedrobaeza commented Feb 29, 2024

legalsylvain commented Feb 29, 2024

StefanRijnhart Apr 1, 2024

StefanRijnhart Apr 1, 2024

StefanRijnhart Apr 1, 2024 •

edited

hbrunn Apr 8, 2024

rvalyi Apr 1, 2024 •

edited

legalsylvain Apr 8, 2024

rvalyi Apr 8, 2024

hbrunn Apr 8, 2024

legalsylvain Apr 8, 2024

StefanRijnhart commented Apr 26, 2024

StefanRijnhart commented Apr 26, 2024

MiquelRForgeFlow commented May 22, 2024

StefanRijnhart commented May 23, 2024

		@@ -0,0 +1,4 @@
		Many developers have contributed to the OpenUpgrade framework in its
		previous incarnation. Their original contributions may no longer needed,

[17.0][OU-ADD] openupgrade_framework: framework patches #4327

[17.0][OU-ADD] openupgrade_framework: framework patches #4327

Conversation

acpMicrocom commented Feb 28, 2024

legalsylvain left a comment

Choose a reason for hiding this comment

acpMicrocom commented Feb 28, 2024

legalsylvain left a comment

Choose a reason for hiding this comment

pedrobaeza commented Feb 29, 2024

legalsylvain commented Feb 29, 2024

StefanRijnhart Apr 1, 2024

Choose a reason for hiding this comment

StefanRijnhart Apr 1, 2024

Choose a reason for hiding this comment

StefanRijnhart Apr 1, 2024 • edited

Choose a reason for hiding this comment

hbrunn Apr 8, 2024

Choose a reason for hiding this comment

rvalyi Apr 1, 2024 • edited

Choose a reason for hiding this comment

legalsylvain Apr 8, 2024

Choose a reason for hiding this comment

rvalyi Apr 8, 2024

Choose a reason for hiding this comment

hbrunn Apr 8, 2024

Choose a reason for hiding this comment

legalsylvain Apr 8, 2024

Choose a reason for hiding this comment

StefanRijnhart commented Apr 26, 2024

StefanRijnhart commented Apr 26, 2024

MiquelRForgeFlow commented May 22, 2024

StefanRijnhart commented May 23, 2024

StefanRijnhart Apr 1, 2024 •

edited

rvalyi Apr 1, 2024 •

edited