Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][OU-ADD] purchase_picking_state: Merged into purchase_stock #4325

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Feb 28, 2024

Related to OCA/purchase-workflow#2081

Merged into purchase_stock (receipt_status field)

Please @pedrobaeza can you review it?

@Tecnativa TT47855

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be a migration script renaming the column and mapping the option values to the former ones?

@victoralmau
Copy link
Member Author

Shouldn't there be a migration script renaming the column and mapping the option values to the former ones?

Interesting, but I'm not sure if doing so is the best thing to do (case of all cancelled pickings) OCA/purchase-workflow#2081 (comment)

@pedrobaeza pedrobaeza added this to the 16.0 milestone Feb 28, 2024
@pedrobaeza
Copy link
Member

I think we can plan it this way:

  • Add the merge in apriori as it is here.
  • Add in the purchase_stock migration scripts that if we find the old column from this module, copy it with the name, and transform values. Cancelled status is passed to NULL, as stated in my comment on the PR.
  • Still on purchase_stock, if we don't find the column, we pre-create it and fill it according the rules of the computed field.

I'm going to speed up purchase migration scripts PR for merging it, so that we add the purchase_stock ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants