[16.0][OU-ADD] loyalty #4187
Open
[16.0][OU-ADD] loyalty #4187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot migration loyalty |
chienandalu
reviewed
Oct 24, 2023
pedrobaeza
reviewed
Oct 24, 2023
pilarvargas-tecnativa
force-pushed
the
16.0-mig-loyalty
branch
3 times, most recently
from
fcfcc65
to
e171bdd
Compare
chienandalu
suggested changes
Nov 2, 2023
openupgrade_scripts/scripts/loyalty/16.0.1.0/noupdate_changes.xml
Outdated
Show resolved
Hide resolved
pilarvargas-tecnativa
force-pushed
the
16.0-mig-loyalty
branch
10 times, most recently
from
b7584b1
to
824798f
Compare
chienandalu
reviewed
Nov 10, 2023
pilarvargas-tecnativa
force-pushed
the
16.0-mig-loyalty
branch
from
824798f
to
735c874
Compare
pilarvargas-tecnativa
force-pushed
the
16.0-mig-loyalty
branch
from
735c874
to
5912a50
Compare
xtanuiha
reviewed
May 15, 2024
| openupgrade.rename_xmlids(env.cr, _xmlids_renames) | ||
| # Renamed in rename_xmlids method. | ||
| # In v15 are noupdate=1 and in v16 are noupdate=0 | ||
| openupgrade.set_xml_ids_noupdate_value( |
There was a problem hiding this comment.
The error message when testing the upgrade script is as follows:
odoo.exceptions.UserError: XML IDs mail_template_loyalty_card must be a tuple or list!
These lines of code can be changed to:
openupgrade.set_xml_ids_noupdate_value(
env, "loyalty", ["mail_template_loyalty_card"], False
)
openupgrade.set_xml_ids_noupdate_value(
env, "loyalty", ["gift_card_product_50"], False
)There was a problem hiding this comment.
thanks
pilarvargas-tecnativa
force-pushed
the
16.0-mig-loyalty
branch
from
5912a50
to
040d8e9
Compare
TT44332
pilarvargas-tecnativa
force-pushed
the
16.0-mig-loyalty
branch
from
040d8e9
to
57af6c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT44332
@chienandalu @ernesto-garcia-tecnativa please review
ping @pedrobaeza