[15.0][OU-FIX] website: unlink view when extract footer copyright company name #4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienandalu
reviewed
Aug 25, 2023
pilarvargas-tecnativa
force-pushed
the
15.0-ou-fix-website-footer_copyright_company_name
branch
from
472060a
to
d3ca20b
Compare
TT44794 The duplicate view of website.layout with associated website needs to be removed as in v15 this view should not be duplicated and if not removed it causes inheritance problems which are aggravated when there is more than one website.
pilarvargas-tecnativa
force-pushed
the
15.0-ou-fix-website-footer_copyright_company_name
branch
from
d3ca20b
to
0dda87a
Compare
chienandalu
reviewed
Aug 25, 2023
| @@ -36,6 +44,7 @@ def extract_footer_copyright_company_name(env): | |||
| or f"Copyright © {website.company_id.name}", | |||
| ) | |||
| main_copyright_view.with_context(website_id=website.id).arch_db = new_arch | |||
| _delete_views_recursively(view) | |||
There was a problem hiding this comment.
This is pretty dangerous, you don't have control at this point of the script about what you're going to delete.
Wouldn't the way to go just changing the inheritance to the new views and the deleting the old ones safely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT44794
The duplicate view of website.layout with associated website needs to be removed as in v15 this view should not be duplicated and if not removed it causes inheritance problems which are aggravated when there is more than one website.
@pedrobaeza @chienandalu please review