[12.0][FIX] base: postgres subprocess error when dumping database #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Odoo is installed with the latest version of the PostgreSQL client (postgres-client or postgres-client-16) and running in Docker (possibly other environments as well but not reproduced so far), executing `pg_dump` via `exec_pg_command` fails with
Database backup error: Postgres subprocess ('/usr/bin/pg_dump', '--no-owner', '--file=/tmp/tmpmnqiktog/dump.sql', '15TEST') error 1
This seems to be because `os.devnull` is being opened in *read* mode which is incorrect (as it's written to). It's not entirely clear if older `pg_dump` simply ignored the non-writable stdout or if docker adds some restrictions which cause the failure.
Either way this can be solved by either opening `os.devnull` in write mode or switching to the `DEVNULL` constant. While the function is deprecated in 16.0 (7f14631) and removed in master (ae3056f) the latter is not a huge change and it a touch cleaner.
fixes odoo#139687
closes odoo#143198
Forward-port-of: odoo#142987
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
igallart
force-pushed
the
FIX_pg_dump_12
branch
from
faa4a22
to
27f91a8
Compare
rafamarpe
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Odoo is installed with the latest version of the PostgreSQL client (postgres-client or postgres-client-16) and running in Docker (possibly other environments as well but not reproduced so far), executing
pg_dumpviaexec_pg_commandfails withThis seems to be because
os.devnullis being opened in read mode which is incorrect (as it's written to). It's not entirely clear if olderpg_dumpsimply ignored the non-writable stdout or if docker adds some restrictions which cause the failure.Either way this can be solved by either opening
os.devnullin write mode or switching to theDEVNULLconstant. While the function is deprecated in 16.0 (7f14631) and removed in master (ae3056f) the latter is not a huge change and it a touch cleaner.fixes odoo#139687
closes odoo#143198