-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP][14.0] enable negative invoices for italian localization #1200
base: 14.0
Are you sure you want to change the base?
[IMP][14.0] enable negative invoices for italian localization #1200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the goal is to get it merged, it would probably be better to test if the company_id.country_id.code is in ("IT",) or something similar to avoid being lenient in other countries where it should be blocked.
1d7c7f9
to
d0932f2
Compare
Good hint, fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically not an Odoo backport but not a big change either so LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kind of changes shouldn't be done here. OCB is not for this. Apart from the ugly hack checking country, this will create a difference experience using Vanilla Odoo or OCB. This should be done on an extra module.
d0932f2
to
704500b
Compare
Fixed the ugly part, I think. I opened a PR on 16.0 version too, ASAP I'll do on Odoo. |
The other part of the reasoning is still blocking. |
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr