Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP][14.0] enable negative invoices for italian localization #1200

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

sergiocorato
Copy link

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@sergiocorato sergiocorato changed the title [IMP][14.0] enable negative invoice for italian localization [IMP][14.0] enable negative invoices for italian localization Oct 26, 2023
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the goal is to get it merged, it would probably be better to test if the company_id.country_id.code is in ("IT",) or something similar to avoid being lenient in other countries where it should be blocked.

@sergiocorato sergiocorato force-pushed the 14.0-imp-account-enable-negative-invoice branch from 1d7c7f9 to d0932f2 Compare October 26, 2023 15:37
@sergiocorato
Copy link
Author

if the goal is to get it merged, it would probably be better to test if the company_id.country_id.code is in ("IT",) or something similar to avoid being lenient in other countries where it should be blocked.

Good hint, fixed.

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically not an Odoo backport but not a big change either so LGTM.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of changes shouldn't be done here. OCB is not for this. Apart from the ugly hack checking country, this will create a difference experience using Vanilla Odoo or OCB. This should be done on an extra module.

@sergiocorato sergiocorato force-pushed the 14.0-imp-account-enable-negative-invoice branch from d0932f2 to 704500b Compare October 26, 2023 20:35
@sergiocorato
Copy link
Author

This kind of changes shouldn't be done here. OCB is not for this. Apart from the ugly hack checking country, this will create a difference experience using Vanilla Odoo or OCB. This should be done on an extra module.

Fixed the ugly part, I think. I opened a PR on 16.0 version too, ASAP I'll do on Odoo.

@pedrobaeza
Copy link
Member

The other part of the reasoning is still blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants