Galaxy WL reformulation

[caioolivv]

New galaxy weak lensing mass estimate model with the following structure:

• NcGalaxyWLLikelihood object which contains the following objects:
  • NcGalaxySampleDistributionPosition with information on source position and redshift;
  • NcGalaxySampleDistributionShape with information on intrinsic shape, observed shape and the shear mapping;
  • NcGalaxySampleDistributionZProxy with information on proxy redshift;

[caioolivv]

There are some problems to solve still:

1. I had to name new object nc_galaxy_wl_likelihood in order to not mess with previous naming scheme. I don't think that's the best name.
2. nc_galaxy_wl_likelihood currently has 2 methods eval_m2lnP and kde_eval_m2lnP for each of the methods. I don't know if that's the best way to present these methods. We can use a flag maybe?
3. I still have to implement the likelihood algorithms, both for KDE and integration (we should discuss the integration algorithm you mentioned @vitenti).
4. If we wish to use different source positions priors and descriptions (i.e. using coordinates, $r$ or $\theta$) it might be best to make nc_galaxy_sd_position contain other two objects describing image position and redshift separately. This may not be necessary if we're not dealing with miscentering.
5. I think it's worth considering adding a way to deal with shape measurement error. Maybe by creating an optional object nc_galaxy_sd_shape_m_err witch could be contained by nc_galaxy_sd_shape.

Also, I'm already working on unit testing. That should be up today still.

[coveralls]

coverage: 68.06% (+0.7%) from 67.336%
when pulling 33b05a1 on wl_rebuild
into fc63c39 on master.

[caioolivv]

I can't create unit tests yet since I haven't implemented nc_galaxy_sd_*_new () and thus can't create neither nc_galaxy_sd_* objects nor nc_galaxy_wl_likelihood objects by extension. Maybe we merge the PR without unit testing while I work on the implementation of basic nc_galaxy_sd_* objects?

Also, I need some directions on how to write these new objects on numcosmo-docs.sgml.

[codecov]

Codecov Report

Attention: Patch coverage is 95.94334% with 63 lines in your changes are missing coverage. Please review.

Project coverage is 67.40%. Comparing base (fc63c39) to head (33b05a1).

Files	Patch %	Lines
numcosmo/galaxy/nc_galaxy_sd_position.c	83.13%	14 Missing ⚠️
numcosmo/model/nc_hicosmo_de.c	16.66%	10 Missing ⚠️
numcosmo/galaxy/nc_galaxy_sd_position_lsst_srd.c	91.66%	9 Missing ⚠️
numcosmo/galaxy/nc_galaxy_sd_shape.c	74.07%	7 Missing ⚠️
numcosmo/galaxy/nc_galaxy_sd_z_proxy.c	76.66%	7 Missing ⚠️
numcosmo/data/nc_data_cluster_wl.c	97.84%	6 Missing ⚠️
numcosmo/galaxy/nc_galaxy_sd_z_proxy_dirac.c	83.33%	6 Missing ⚠️
numcosmo/galaxy/nc_galaxy_sd_position_flat.c	95.23%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   66.67%   67.40%   +0.72%     
==========================================
  Files         494      504      +10     
  Lines       86952    87711     +759     
==========================================
+ Hits        57975    59121    +1146     
+ Misses      28977    28590     -387     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.