Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flush data still available in the decoder when no input #129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

flush data still available in the decoder when no input #129

wants to merge 1 commit into from

Conversation

nl5887
Copy link
Contributor

@nl5887 nl5887 commented Sep 23, 2021 •
edited by robjtede

closes #123

@michalfita
Copy link

michalfita commented Jul 1, 2022 •
edited

@nl5887 any chance this could be pushed up the priorites list, please?
This fix works for us for some time and we'd really like to return to upstream releases.

Thanks in advance.

@Nemo157
Copy link
Member

Nemo157 commented Jul 14, 2022

I would really like a testcase with this to make sure it does fix the issue and there won't be a regression. I'll probably take another try at writing one myself, but I remember failing at it once already.

@robjtede robjtede added the A-semver-patch bug fixes label May 10, 2023
NobodyXu
NobodyXu requested changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase this PR against main?

@michalfita
Copy link

@nl5887 isn't recently very active on GH, hopefully he gets this ping.

@robjtede robjtede changed the title flush data still available in the decoder when no input (#123) flush data still available in the decoder when no input Sep 19, 2023
@robjtede robjtede mentioned this pull request Sep 19, 2023
Merged
@robjtede
Copy link
Member

Since this PR has not allowed maintainer edits, I've rebased and opened #247.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A-semver-patch bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decoder might block if there is data remaining to be flushed from the codec and the stream blocks
5 participants
@nl5887 @michalfita @Nemo157 @robjtede @NobodyXu