[MIRROR] Fixed the ipintel subsystem not initializing #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinylspiders
approved these changes
May 6, 2024
NovaBot13
added a commit
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: tgstation/tgstation#82936
About The Pull Request
Subsystem had the SS_INIT_NO_NEED inside of its subsystem flags. This is not a flag and has a value of 3, which includes the SS_NO_INIT and SS_NO_FIRE flags, which stopped it from initializing.
The subsystem has things it needs to do in init, so I've replaced this flag with SS_OK_TO_FAIL_INIT so that it can pass unit tests, but still be okay to fail.
Why It's Good For The Game
Fixes the ipintel subsystem not working.
Changelog
馃啈
fix: Fixed the ipintel subsystem not working.
/:cl: