feat: add toggle preview json to copy to manifest.json #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotWoods
requested changes
May 18, 2021
There was a problem hiding this comment.
I like this feature idea! I'd like to replace some code with native tools that achieve the same effect. It would also be great to have some help text above/below the JSON that says where to put it. You can use:
Copy this JSON into the
"icons"array of your Web App Manifest
| @@ -297,6 +309,12 @@ <h2 id="modalTitle">Export</h2> | |||
| </label> | |||
| </div> | |||
|
|
|||
| <div> | |||
| <a href="#" class="dialog-action-link" id="showPreviewArrayIcons">Show JSON</a> | |||
There was a problem hiding this comment.
I'd like to use the <details>/<summary> elements instead to do the open/close without Javascript.
| sizes: `${size}x${size}`, | ||
| })); | ||
|
|
||
| outputPreview.textContent = JSON.stringify(filteredJson, null, 2); |
There was a problem hiding this comment.
Updating the text is cheap enough that we can just change it everytime the selected checkboxes are changed. That also removes the need for a separate array, you can read sizeInputs.
|
Hi @NotWoods. I'm worning on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that it's more easy to show a json snippet to developer can copy!