Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24813: More change to prepare scala 3 migration #5639

Conversation

fanf
Copy link
Member

@fanf fanf commented Apr 30, 2024

https://issues.rudder.io/issues/24813

See #5548 for the original PR.
I didn't saw anything strange, test pass, rudder seems to work.
Some commit warrant a second sight:

  • provide a total function for messageHandler to avoid pattern matching catchall for future values
    c5098e0
  • (*) rewrite early return function to functional style 613dcfe

That's all, other seems quite automatic / not risky.

@fanf fanf requested a review from VinceMacBuche April 30, 2024 15:31
@fanf
Copy link
Member Author

fanf commented Apr 30, 2024

Merging that PR. Everything seems OK, tests pass, rudder works.

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5639
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/83921/console)

@fanf
Copy link
Member Author

fanf commented May 3, 2024

OK, merging this PR

@fanf fanf merged commit cdcfdd4 into Normation:branches/rudder/8.1 May 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants