Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24784: Nodes page has console error from the tree script #5632

Open
wants to merge 2 commits into
base: branches/rudder/8.1
Choose a base branch
from

Conversation

clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory commented Apr 25, 2024

https://issues.rudder.io/issues/24784

Within the node details page, the group tree was still having disappearing event handlers (even without the console error) :

  • it seems like the previous selectors for tree elements with lift-event-js- id was not applied to the pencils (in the .treeActions container)
  • the rendering of the tree only populates event handlers when the ready.jstree event is fired

N.B. : the use case here and the fix here are specific to the node details page, the groups page renders the tree using Elm and does not use the modified code

Fixes #24784: Nodes page has console error from the tree script
@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant