Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24768: Update Scala dependencies #5624

Conversation

clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory requested a review from fanf April 22, 2024 16:36
@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

Comment on lines +483 to +487
<fs2-version>3.10.2</fs2-version>
<shapeless-version>2.3.10</shapeless-version>
<cats-effect-version>3.5.2</cats-effect-version>
<dev-zio-version>2.0.19</dev-zio-version>
<zio-cats-version>23.1.0.0</zio-cats-version> <!-- gives fs2 3.1.6, but doobie 1.0.0-RC1 is in 3.0.3 -->
<cats-effect-version>3.5.4</cats-effect-version>
<dev-zio-version>2.0.22</dev-zio-version>
<zio-cats-version>23.1.0.2</zio-cats-version> <!-- gives fs2 3.10.2, but doobie 1.0.0-RC5 is in 3.9.3 -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fs2 : 3.3.0 -> 3.10.2 the update of the library does seem to have been forgotten, although cats-effect specifies it needs fs2 3.7.0+ since CE 3.5.0. As far as we know this has been working fine since we updated to 3.5.0 though...

@clarktsiory clarktsiory marked this pull request as draft April 23, 2024 08:37
@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

@@ -422,7 +422,7 @@ limitations under the License.
<rudder-major-version>8.2</rudder-major-version>
<rudder-version>8.2.0~alpha1-SNAPSHOT</rudder-version>

<scala-version>2.13.12</scala-version>
<scala-version>2.13.13</scala-version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not have any issue since we use -Xsource:3-cross when migrating to scala 3

this PR is the one which will migrate to scala 2.13.13, with all needed rewrites : https://github.com/Normation/rudder/pull/5548/files

@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

1 similar comment
@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

@clarktsiory clarktsiory marked this pull request as ready for review April 23, 2024 14:43
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5624
-- Your faithful QA
Kant merge: "To be is to do."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/83993/console)

@clarktsiory
Copy link
Contributor Author

OK, squash merging this PR

@clarktsiory clarktsiory force-pushed the arch_24768/update_scala_dependencies branch from fee6a43 to d7bf321 Compare May 3, 2024 07:54
@clarktsiory clarktsiory merged commit d7bf321 into Normation:master May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants