Fixes #24762: Add basic elm-review config #5620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
force-pushed
the
arch_24762/add_basic_elm_review_config
branch
from
f2ffb90
to
1436b0d
Compare
|
PR updated with a new commit |
5 similar comments
|
PR updated with a new commit |
|
PR updated with a new commit |
|
PR updated with a new commit |
|
PR updated with a new commit |
|
PR updated with a new commit |
RaphaelGauthier
approved these changes
May 2, 2024
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
amousset
force-pushed
the
arch_24762/add_basic_elm_review_config
branch
from
5e0071f
to
5a7b98d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24762
Requires upgrading the node versions used on the CI. Using Node 20 LTS.
I started from jfmengel's "starter pack" for applications, and disabled most rules to allow easy integration, but some rules are interesting, especially some suggestions of the Simplify rule.
Detected and removed 3 unused dependencies: