Fixes #24701: Add daily schedule for campaign #5594
+72
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
VinceMacBuche
force-pushed
the
enh_24701/add_daily_schedule_for_campaign
branch
from
99efd2d
to
f4f6c03
Compare
fanf
reviewed
Apr 16, 2024
| }).withHourOfDay(end.realHour).withMinuteOfHour(end.realMinute).withSecondOfMinute(0).withMillisOfSecond(0) | ||
| } | ||
|
|
||
| Some((startDate, endDate)).succeed |
There was a problem hiding this comment.
I think we want to limit the max span to 20h or so to avoid all the borderline cases when two campaign override (ie, we don't even want to have to wonder what would happen).
At least, it needs to be less than 24h
There was a problem hiding this comment.
see comment in other PR: it should work. Let it be like that as @VinceMacBuche asked.
|
I think the doc for system update API needs to be updated to explain the new data type alternative |
|
Commit modified |
VinceMacBuche
force-pushed
the
enh_24701/add_daily_schedule_for_campaign
branch
from
f4f6c03
to
a5e6305
Compare
|
PR rebased |
VinceMacBuche
force-pushed
the
enh_24701/add_daily_schedule_for_campaign
branch
from
a5e6305
to
ab8ce6d
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
enh_24701/add_daily_schedule_for_campaign
branch
from
ab8ce6d
to
009e3f9
Compare
|
api doc added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24701