Fixes #24627: We can add the same score details column many times in nodes tables #5568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarktsiory
force-pushed
the
bug_24627/we_can_add_the_same_score_details_column_many_times_in_nodes_tables
branch
from
4fa5752
to
0ccb36b
Compare
|
Same as #5566 i need some time to review it. i have not forgotten it |
|
Can be replaced by: https://github.com/Normation/rudder/pull/5645/files which also treat software removal cases (also there is a bug in global score removal here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24627
⚠️ This PR is based on #5566 which should be merged before ⚠️
The second commit is the meaningful one.
Now we cannot add a column when the score details is already in the table.
We always keep the "Score details" selected, even if the value is empty (all score options have been added).