Fixes #24280: When we clone a technique with resource, the clone does not really have the resource

[VinceMacBuche]

https://issues.rudder.io/issues/24280

[amousset]

Suggested change

	techniqueId <- restExtractorService.extractString("techniqueId")(req)(Full(_)).toIO.notOptional("category parameter is missing")
	techniqueId <- restExtractorService.extractString("techniqueId")(req)(Full(_)).toIO.notOptional("technique id parameter is missing")

[fanf]

please avoid strings for global vars. Ideally they should be services for easier testing, or at lest something provided centrally in an object.

[fanf]

Can you explain the general idea here ? There's several things I don't get:

• why does it need it's dedicated public API endpoint for something that looks like a very internal process implementation ? I would understand a general API "clone", but "copy resource when cloning" is really looking like an internal step, not an API usable by users
• why do you need Bytes in the elm part?
• I don't understand how cloning resources from a draft work either

[VinceMacBuche]

Commit modified

[VinceMacBuche]

Commit modified

[fanf]

When I clone a technique with an existing resource, the resource is cloned. But as soons as I try to modify the technique name, I get a lot of error notif in UI, and the following stack trace in logs:

 -> com.normation.rudder.ncf.GitResourceFileService.$anonfun$cloneResourcesFromTechnique$1(ResourceFileService.scala:147)
 -> com.normation.zio$ZioRuntime$.$anonfun$unsafeRun$1(ZioCommons.scala:445)
 -> com.normation.zio$ZioRuntime$.unsafeRun(ZioCommons.scala:445)
 -> com.normation.zio$ZioRuntime$.runNow(ZioCommons.scala:428)
 -> com.normation.zio$UnsafeRun.runNow(ZioCommons.scala:454)
 -> com.normation.rudder.rest.RudderJsonResponse$implicits$ToLiftResponseOne.toLiftResponseOne(RudderJsonResponse.scala:220)
 -> com.normation.rudder.rest.RudderJsonResponse$implicits$ToLiftResponseOne.toLiftResponseOne(RudderJsonResponse.scala:232)
 -> com.normation.rudder.rest.lift.TechniqueApi$CopyResourcesWhenCloning$.process(TechniqueApi.scala:235)
 -> com.normation.rudder.rest.lift.TechniqueApi$CopyResourcesWhenCloning$.process(TechniqueApi.scala:216)
 -> com.normation.rudder.rest.lift.LiftApiModule.handler(LiftApiDispatcher.scala:67)
 -> com.normation.rudder.rest.lift.LiftApiModule.handler$(LiftApiDispatcher.scala:59)
 -> com.normation.rudder.rest.lift.TechniqueApi$CopyResourcesWhenCloning$.handler(TechniqueApi.scala:216)
 -> com.normation.rudder.rest.lift.TechniqueApi$CopyResourcesWhenCloning$.handler(TechniqueApi.scala:216)
 -> com.normation.rudder.rest.BuildHandler.$anonfun$buildApi$21(ApiDatastructures.scala:696)
 -> com.normation.rudder.rest.BuildHandler.$anonfun$buildApi$18(ApiDatastructures.scala:680)
 -> com.normation.rudder.rest.BuildHandler.$anonfun$buildApi$15(ApiDatastructures.scala:674)
 -> com.normation.rudder.rest.BuildHandler.$anonfun$buildApi$15$adapted(ApiDatastructures.scala:672)```


Plus, the copy API it still public, it should be private. 

The clone of template with resources works great :+1: 

[VinceMacBuche]

Commit modified

[VinceMacBuche]

I fixed the elm section, we were cloning resource at every edition, when we updated clone: https://github.com/Normation/rudder/pull/5453/files#diff-a4856d1cc4cf1a4d42d660a6e4c3f98072e5f685683419c57d1cd6f2612a0843R617 , it should only be done at clone ( https://github.com/Normation/rudder/pull/5453/files#diff-093c6a0e361570c9b6c31d97a4be6ef77d965334ffac9024abf42cf9badf9671R312 )

I set the api to private too https://github.com/Normation/rudder/pull/5453/files#diff-a4856d1cc4cf1a4d42d660a6e4c3f98072e5f685683419c57d1cd6f2612a0843R617

[fanf]

Great, works as expected, code is neat!

[fanf]

OK, merging this PR