Fixes #22088: make iterator report more independent #1375
Conversation
| ##### | ||
| # Actual command - for actions, non using systemd | ||
| ##### | ||
| pass2.is_check_action.!is_process_action.method_found.action_ok:: | ||
| "${report_data.method_id}" usebundle => _classes_success("${class_prefix}"); | ||
| "${report_data.method_id}" usebundle => _classes_success("${report_data.method_id}"); | ||
| "${report_data.method_id}" usebundle => _classes_success("${report_data.report_id}"); |
There was a problem hiding this comment.
this won't allow making a difference in methods calling several other methods.
There was a problem hiding this comment.
all will use the same prefix, method_id is there for a reason
There was a problem hiding this comment.
method_id and report_id were using the same value
There was a problem hiding this comment.
"report_data.report_id" string => canonify("${report_id}_${report_data.directive_id}");
"report_data.method_id" string => canonify("${report_id}_${report_data.directive_id}");
There was a problem hiding this comment.
So if you have the problem with report_id then you had the problem with method_id
Hence this pr makes method id even more specific (and i keep use it as promiser because of this) as it allow reexecution of things that were not reexecuted
There was a problem hiding this comment.
Anyway i made this changed in 7.2 but i think it should be on master
There was a problem hiding this comment.
method_id is modified each time we enter a sub-method (by the push/pop mechanism), report_id stays the same. What is in _method_reporting_context_v4 is only the initialization.
VinceMacBuche
changed the title
| # Canonified version, to be used in policies (as class prefix) | ||
| # it needs the directive_id to enforce unicity | ||
| "report_data.report_id" string => canonify("${report_id}_${report_data.directive_id}"); | ||
| "report_data.method_id" string => canonify("${report_id}_${report_data.directive_id}_${report_data.index}"); |
There was a problem hiding this comment.
this change looks really complex.
we need to clearly define what is expected in report, method, and why index is necessary like (why not use something else like an auto generated id from the webapp)
there are many moving parts, in services, packages in 20_services, but also in system techniques.
There was a problem hiding this comment.
I just added an id to track the iteration on a method
There was a problem hiding this comment.
replaced usage a method_id to report_id (they were the same value)
There was a problem hiding this comment.
To use report_id effectively in reports and method_id where we need to identify the method
VinceMacBuche
force-pushed
the
bug_22088/make_iterator_report_more_independant
branch
from
f7d1898
to
5bfe728
Compare
No description provided.