Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gas-provider error caused by empty blocks #3851

Conversation

LEAFERx
Copy link

@LEAFERx LEAFERx commented Apr 11, 2023

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

On a chain that supports EIP-1559, when there's an empty block, the reward returned from eth_feeHistory will be 0. However, AutomaticGasPriceProvider should set maxPriorityFeePerGas to be at least 1 to avoid ProviderError: FeeTooLow, EffectivePriorityFeePerGas too low 0 < 1.

This bug is found on Chiado, a minimal reproducible example and detailed analysis can be found here.

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2023

⚠️ No Changeset found

Latest commit: ae97f87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2023 11:49pm
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2023 11:49pm

@alcuadrado
Copy link
Member

Hey, sorry we never merged this, and thanks for sending this PR. I'm closing it as I believe it has already been fixed.

@alcuadrado alcuadrado closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants