Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first attempt to add nodeos-standard to NodeOS #294

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TylerLeonhardt
Copy link
Contributor

So all the important stuff is in the package.json

We're using nodeos-standard 0.2.0 which includes allman style.

You'll notice the command: "csCheck": "nodeos-standard $(grep -ril './scripts' -e '/usr/bin/env node') ; exit 0" This does a few things...

  1. it grabs all the files in the scripts folder that are to be run with Node assuming that they are javascript... This was needed because ESLint tried to give feedback on bash scripts... lol

  2. the ; exit 0 at the end ensures that the script is purely informative and doesn't crash the whole execution of whatever it's doing.

I added npm run csCheck to the end of npm test as I figured the tests can run and than the code style can be checked.

Let me know what you think!

We'd do something like this in every NodeOS repo.

Cheers!

@aulvi
Copy link
Member

aulvi commented Aug 19, 2016

@tylerl0706 I suggest you drop the camelCase name in favor of a dash.

csCheck vs cs-check

Using dashes avoids case sensitivity issues on Windows and Linux and is more inline with common Node conventions.

@TylerLeonhardt
Copy link
Contributor Author

@aulvi done :)

@TylerLeonhardt
Copy link
Contributor Author

@piranna: can you take a look at why this failed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants