New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Helm Chart Support #12189
base: develop
Are you sure you want to change the base?
Basic Helm Chart Support #12189
Conversation
💡 Friendly NoteThis pull request was made against the
Thanks! |
Basic manual integration tests with MongoDB works very well with both replicaset and standalone mode! Will try other databases and manual case too! |
and with postgres also tested and working as expected...I think the charts are ready, maybe we can improve the testing infra later on. |
Also manually tested on my own Oracle Cloud K8S cluster with ARM64. As expected, it worked like a charm. The only problem is that managed mongo won't work on ARM64, since it was blocked by bitnami/containers#40947 (comment). You may have to go far out to use the official MongoDB K8S operator in order to get it to work. |
@oplik0 @barisusakli Maybe we should move this out of the NodeBB main repo, can you guys make a |
Seems like a good idea for expanding on CI and testing - while the releaser itself isn't an issue (since it seems to run pretty quickly) I imagine the additional testing might add a few minutes to Actions runtime. It does make automatically running CI a bit more complicated - probably the docker workflow will need to call workflow dispatch via GH API - but it shouldn't be that bad. I can't make the repo though since I'm just a contributor and don't have any special access to NodeBB org :) Also, on Dependabot, NodeBB is using Renovate instead and it supports Helm out of the box. Dependabot is developing very slowly (outside of the notification spam part) so I'm really not sure if they support Helm yet. |
@oplik0 Should we further cache the Verdaccio packages in GHA or is it just fine? Right now, the basic integration test takes about 10 minutes (20 minutes using act, a GHA simulator, I'm not sure why), and the time to run it can be a detrimental cost to the testing pipeline, so it is better to split it off to another repo and do the tests on demand. |
In a separate repo I think it'll be fine. Thankfully GitHub doesn't charge for CI in public repos (since, considering their LFS billing model, it probably wouldn't be usable :) and it shouldn't stall the entire NodeBB pipeline in that case. |
@julianlam Maybe you would be the right person to make that repo tho? |
Implemented items per the requirements on #12178
Missing items:
Interesting stuff: