Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom favicon #11970

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: custom favicon #11970

wants to merge 2 commits into from

Conversation

noscripter
Copy link
Contributor

if favicon was uploaded and not stored in static upload folder, this logic is wrong, it should be used from Meta.config instead.

if favicon was uploaded and not stored in static upload folder, this logic is wrong, it should be used from Meta.config instead.
@barisusakli
Copy link
Member

@noscripter what was the value stored in meta.config['brand:favicon']?

The code seems to always save the file at public/uploads/system/favicon.ico

@noscripter
Copy link
Contributor Author

@barisusakli that's not the case when you use some plugins to override the uploadFavicon function found in ACP. Oh, I see, I've customized this function to response to the hook filter:uploadImage. Maybe this could be proposed to change too, I'll come up with these changes later for you to check out.🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants