test: fixed improper signed_string reconstruction in .verify()

NodeBB · Aug 9, 2023 · 6a5b0fa · 6a5b0fa
1 parent e2bb293
commit 6a5b0fa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/activitypub/index.js b/src/activitypub/index.js
@@ -136,7 +136,7 @@ ActivityPub.verify = async (req) => {
 	// Re-construct signature string
 	const signed_string = headers.split(' ').reduce((memo, cur) => {
 		if (cur === '(request-target)') {
-			memo.push(`${cur}: ${String(req.method).toLowerCase()} ${req.path}`);
+			memo.push(`${cur}: ${String(req.method).toLowerCase()} ${req.baseUrl}${req.path}`);
 		} else if (req.headers.hasOwnProperty(cur)) {
 			memo.push(`${cur}: ${req.headers[cur]}`);
 		}

diff --git a/test/activitypub.js b/test/activitypub.js
@@ -261,9 +261,11 @@ describe('ActivityPub integration', () => {
 		describe('.verify()', () => {
 			let uid;
 			let username;
+			const baseUrl = nconf.get('relative_path');
 			const mockReqBase = {
 				method: 'GET',
 				// path: ...
+				baseUrl,
 				headers: {
 					// host: ...
 					// date: ...