neovim: Update bundled tree-sitter parsers #312312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bew
force-pushed
the
fix/neovim-bundled-parsers
branch
from
217d03c
to
782ad57
Compare
kevincox
approved these changes
May 17, 2024
|
Result of 1 package marked as broken and skipped:
1 package failed to build:
1807 packages built:
|
|
Result of 3 packages marked as broken and skipped:
1 package failed to build:
1773 packages built:
|
|
Result of 1 package marked as broken and skipped:
1 package failed to build:
1776 packages built:
|
|
nixpkgs-review doesn't tell the whole story here. The nix grammars seem to match neovim's. I've built it locally and I was able to open markdown/help files with |
|
This is failing for me using … while evaluating derivation 'bash-grammar-neovim-9ca81b0'
whose name attribute is located at /nix/store/r8nhgnkxacbnf4kv8kdi8b6ks3k9b16i-source/pkgs/stdenv/generic/make-derivation.nix:331:7
… while evaluating attribute 'src' of derivation 'bash-grammar-neovim-9ca81b0'
at /nix/store/r8nhgnkxacbnf4kv8kdi8b6ks3k9b16i-source/pkgs/by-name/ne/neovim-unwrapped/package.nix:179:31:
178| ${tree-sitter.buildGrammar {
179| inherit (grammar) src;
| ^
180| version = "neovim-${finalAttrs.version}";
error: attribute 'src' missing
at /nix/store/r8nhgnkxacbnf4kv8kdi8b6ks3k9b16i-source/pkgs/by-name/ne/neovim-unwrapped/package.nix:179:31:
178| ${tree-sitter.buildGrammar {
179| inherit (grammar) src;
| ^
180| version = "neovim-${finalAttrs.version}";
Did you mean url? |
|
@gvolpe are you using nightly by any chance ? I had the same error but using nixpkgs' neovim fixed it. I will try to fix nightly in the upcoming days |
|
@teto yeah spot on, it only fails with nightly, works with the latest stable v0.10.0 👍🏽 |
|
Calling attention to a regression: inline highlighting (```<lang>) is broken for me after updating, with the error noted in #312763 displayed by edit: Actually, it seems like inline highlighting isn't broken anymore? I don't know that I did anything to fix it. Still getting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update bundled parsers (+ updater)
New deps are in: https://github.com/neovim/neovim/blob/06135cc21571b2707121e31176f544a0e0901e1d/cmake.deps/deps.txt
To avoid issues like #311047 (comment)
I'm currently having issues to build theneovimpackage as the tree-sitter-markdown repo actually has 2 parsers 🤔Will check how it's packaged in nixpkgs, to see how to update neovim's env build..
I copied the parser overrides for the markdown parsers as is done here:
nixpkgs/pkgs/development/tools/parsing/tree-sitter/default.nix
Lines 72 to 73 in ea77cef
I quickly tested things by opening a few files and checked with
⚠️ I'm not 100% sure how to check that the
:InspectTreethat the parser is correctly working.markdown_inlineparser works though, every line of a markdown document are marked asinlinebut it doesn't go down into themarkdown_inlineparser. Do I need thenvim-treesitterplugin for that to work?Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.